Follow-up to #2983568: Audit and improve focus styles across the Umami theme for logged out users, filed so we can get all the other successful improvements from that issue committed.

Problem/Motivation

The main menu links in Firefox get an outline, but the top side is missing. Firefox screenshot:
Firefox screenshot shows main menu links in focus. The top side of the outline is missing.

This was fixed for Chrome in the previous issue, and works well. Chrome screenshot:
Firefox screenshot shows main menu links in focus. The link is outlined on all 4 sides.

Proposed resolution

Check this in IE, Edge, Safari
Fix.

Remaining tasks

Fix.
Cross-browser testing.

Comments

andrewmacpherson created an issue. See original summary.

jogordon’s picture

I've picked this up at #uoe-d8-contribution

jogordon’s picture

Can't replicate this issue and can't see the dotted line. Is there an accessibility setting switched on that activates the dotted line borders? What version of Firefox is being used here?

andrewmacpherson’s picture

Title: Umami main menu focus style is missing the top outline in Firefox » [PP-1] Umami main menu focus style is missing the top outline in Firefox
Status: Active » Postponed

Thanks for picking this up. Sorry, this may be a confusing one, because it's is a follow-up to #2983568: Audit and improve focus styles across the Umami theme for logged out users, which hasn't been committed yet. This isn't our usual way of working though - in this case the previous issue is quite epic, an this was deferred so that it wouldn't hold up all the wins in the main issue. It's probably best to leave this issue until after that one is committed. I've marked this postponed, and I'll set it back to active when at the right time.

Is there an accessibility setting switched on that activates the dotted line borders?

That depends on your operating system. MacOS has a setting (a stupid one, IMO) to enable tabbing to links. It's somewhere in the System Settings application. Firefox respects that setting.

andrewmacpherson’s picture

Title: [PP-1] Umami main menu focus style is missing the top outline in Firefox » Umami main menu focus style is missing the top outline in Firefox
Status: Postponed » Active
mcannon’s picture

StatusFileSize
new2.77 MB

I've checked the latest in OSX and Windows on Firefox and it does not seem like the issue exist anymore.
Umami Menu

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

pawandubey’s picture

Status: Active » Closed (cannot reproduce)
StatusFileSize
new49.3 KB

@andrewmacpherson

I have also tested this in Firefox with Drupal 8.8.x version and not able to replicate the same as per the attached screenshot.

Moving this to 'cannot reproduce' status.

andrewmacpherson’s picture

The problem still exists as of the current 8.8.x. See this screenshot:

The problem seems to be overflow on the list wrapper. If I use browser zoom to reduce to 90% scale, the top outline is visible:

Digging around in the CSS, I found these:

core/profiles/demo_umami/themes/umami/css/components/navigation/menu-main/menu-main.css

.menu-main {
  overflow: hidden;
  // ...
}

@media screen and (min-width: 48em) {
  .menu-main {
    // ...
    overflow: auto;
    // ...
  }
  // ...
}

Disabling both of these overflow declarations makes the top outline visible. What are these used for, and is there anything that will break if we remove them?

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

shaal’s picture