ContextHandler should use setContext() not setContextValue()

This change seems very sensible to me.

Eclipse

Thanks @tim.plunkett for documenting the history of the bug and the relationship to #3008431: A context object for a specific entity type will not match a generic requirement for any entity. That gives me confidence that this is a good change and that any side effects from this fix are mitigated in 8.7.x.

One thing -- the final fail patch says "Build Successful". I'm going to queue another run to see if we can get a proper fail

Via @tim.plunkett: CI is obscuring the fail, but it can be seen on Dispatcher:
https://dispatcher.drupalci.org/job/drupal_patches/78334/testReport/juni...

fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-444.xml:
PHPunit Test failed to complete; Error: PHPUnit 6.5.13 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\Core\Plugin\ContextHandlerTest
.......................F....F.                                    30 / 30 (100%)

Time: 345 ms, Memory: 8.00MB

There were 2 failures:

1) Drupal\Tests\Core\Plugin\ContextHandlerTest::testApplyContextMapping
Expectation failed for method name is equal to "setContext" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Drupal\Tests\Core\Plugin\ContextHandlerTest::testApplyContextMappingConfigurableAssigned
Expectation failed for method name is equal to "setContext" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

FAILURES!
Tests: 30, Assertions: 59, Failures: 2.

So we don't actually need a retest.

Let's add a test verifying that we get the EntityContext object when appropriate as described in the IS (and add that test to the fail-patch).

Thanks!

Looks great.

Committed and pushed b33232b7d2 to 8.7.x and 2b93e80229 to 8.6.x. Thanks!

This seems likely to have introduced:
https://www.drupal.org/pift-ci-job/1134931

It's possible this is this is just due to inattentive backporting given the relationship to #3008431: A context object for a specific entity type will not match a generic requirement for any entity documented above. We'll know in an hour or so. Meanwhile, I've reverted it from 8.6.x only.

Yep my mistake. Thanks for the revert. As long as 8.7.x passes I suggest we close this unless the authors want to port a fix to 8.6.x

Yep so the builds are fine. Setting to fixed as per #22. If we want this in 8.6.x then we'll need to port the patch.

As per #3008431: A context object for a specific entity type will not match a generic requirement for any entity, I think this should remain in 8.6.x for now, since there isn't actually direct benefit to the affected project from backporting them alone. The affected project should depend on the next minor.