Local Translator: Display inline translation help in form

For every field on the translation form, if the field is translatable, and if there exist translations in any of the translation skills, we should output the translation to the user, under the label / over the input field. To the right it should be the name of the language.

Comment	File	Size	Author
#21	implement_translation_fields_preview_20.patch	27.33 KB	valentine94
#20	implement_translation_fields_preview_19.patch	27.23 KB	valentine94
#19	implement_translation_fields_preview_18.patch	25.99 KB	valentine94
#18	implement_translation_fields_preview_17.patch	25.88 KB	valentine94
#17	implement_translation_fields_preview_16.patch	20.96 KB	valentine94
#15	implement_translation_fields_preview_15.patch	17.76 KB	valentine94
#14	implement_translation_fields_preview_14.patch	17.75 KB	valentine94
#13	implement_translation_fields_preview_13.patch	15.06 KB	valentine94
#12	implement_translation_fields_preview_12.patch	14.24 KB	valentine94
#11	implement_translation_fields_preview_11.patch	14.49 KB	valentine94
#10	implement_translation_fields_preview_10.patch	14.2 KB	valentine94
#9	implement_translation_fields_preview_9.patch	13.26 KB	valentine94
#8	implement_translation_fields_preview_8.patch	11.95 KB	valentine94
#7	implement_translation_fields_preview_7.patch	11.51 KB	valentine94
#6	interdiff.diff	1.55 KB	valentine94
#6	implement_translation_fields_preview_5.patch	11.46 KB	valentine94
#5	implement_translation_fields_preview_5.patch	11.46 KB	valentine94
#4	implement_translation_fields_preview_4.patch	14.05 KB	valentine94
#3	implement_translation_fields_preview_3.patch	13.09 KB	valentine94
#2	implement_translation_fields_preview_2.patch	12.75 KB	valentine94
	implement_translation_fields_preview_1.patch	8.2 KB	valentine94

Comments

Comment #1

26 November 2018 at 14:36

Valentine94 created an issue. See original summary.

Log in or register to post comments

Comment #2

Kyiv, Ukraine

commented 27 November 2018 at 11:21

Status	File	Size
new	implement_translation_fields_preview_2.patch	12.75 KB

Moved code into the local_translation_content sub-module, fixed cache issue, added user's skills restriction, fixed bug with ajax(on files uploading).

Log in or register to post comments

Comment #3

Kyiv, Ukraine

commented 8 December 2018 at 10:54

Status	File	Size
new	implement_translation_fields_preview_3.patch	13.09 KB

Rework patch with some changes, fixes and optimization

Log in or register to post comments

Comment #4

Kyiv, Ukraine

commented 9 December 2018 at 10:53

Status	File	Size
new	implement_translation_fields_preview_4.patch	14.05 KB

3 files were hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_1.patch	8.2 KB
hidden	implement_translation_fields_preview_2.patch	12.75 KB
hidden	implement_translation_fields_preview_3.patch	13.09 KB

Made some more fixes

Log in or register to post comments

Comment #5

Kyiv, Ukraine

commented 13 December 2018 at 08:52

Status	File	Size
new	implement_translation_fields_preview_5.patch	11.46 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_4.patch	14.05 KB

Reworked code so it's now working for any content entities + fixed bug when the inline help is missing on the translation create form

Log in or register to post comments

Comment #6

Kyiv, Ukraine

commented 16 December 2018 at 11:22

Status	File	Size
new	implement_translation_fields_preview_5.patch	11.46 KB
new	interdiff.diff	1.55 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_5.patch	11.46 KB

Fix failing tests after Drupal core upgrade

Log in or register to post comments

Comment #7

Kyiv, Ukraine

commented 16 December 2018 at 12:03

Status	File	Size
new	implement_translation_fields_preview_7.patch	11.51 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_5.patch	11.46 KB

Uploaded correct patch

Log in or register to post comments

Comment #8

Kyiv, Ukraine

commented 16 December 2018 at 13:01

Status	File	Size
new	implement_translation_fields_preview_8.patch	11.95 KB

Fix bug with inline help when changing source language

Log in or register to post comments

Comment #9

Kyiv, Ukraine

commented 16 December 2018 at 13:51

Status	File	Size
new	implement_translation_fields_preview_9.patch	13.26 KB

Make input element go inside table (marked with language name like the inline translation help)

Log in or register to post comments

Comment #10

Kyiv, Ukraine

commented 20 December 2018 at 09:48

Status	File	Size
new	implement_translation_fields_preview_10.patch	14.2 KB

Update patch so all field elements are going inside the table + some minor fixes

Log in or register to post comments

Comment #11

Kyiv, Ukraine

commented 20 December 2018 at 10:53

Status	File	Size
new	implement_translation_fields_preview_11.patch	14.49 KB

Rework checkboxes fields

Log in or register to post comments

Comment #12

Kyiv, Ukraine

commented 20 December 2018 at 15:52

Status	File	Size
new	implement_translation_fields_preview_12.patch	14.24 KB

Rolled-back last patch + removed "option" class from labels for checkbox fields

Log in or register to post comments

Comment #13

Kyiv, Ukraine

commented 23 December 2018 at 08:50

Status	File	Size
new	implement_translation_fields_preview_13.patch	15.06 KB

Made small fixes for checkboxes and daterange fields

Log in or register to post comments

Comment #14

Kyiv, Ukraine

commented 27 December 2018 at 09:33

Status	File	Size
new	implement_translation_fields_preview_14.patch	17.75 KB

Move "summary" sub-field's preview into the separate table

Log in or register to post comments

Comment #15

Kyiv, Ukraine

commented 27 December 2018 at 12:40

Status	File	Size
new	implement_translation_fields_preview_15.patch	17.76 KB

4 files were hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_11.patch	14.49 KB
hidden	implement_translation_fields_preview_12.patch	14.24 KB
hidden	implement_translation_fields_preview_13.patch	15.06 KB
hidden	implement_translation_fields_preview_14.patch	17.75 KB

Fixed patch applying failure

Log in or register to post comments

Comment #16

Kyiv, Ukraine

commented 27 December 2018 at 12:40

Assigned:

Unassigned

5 files were hidden/shown/deleted

Status	File	Size
hidden	interdiff.diff	1.55 KB
hidden	implement_translation_fields_preview_7.patch	11.51 KB
hidden	implement_translation_fields_preview_8.patch	11.95 KB
hidden	implement_translation_fields_preview_9.patch	13.26 KB
hidden	implement_translation_fields_preview_10.patch	14.2 KB

Log in or register to post comments

Comment #17

Kyiv, Ukraine

commented 28 December 2018 at 09:58

Status	File	Size
new	implement_translation_fields_preview_16.patch	20.96 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_15.patch	17.76 KB

Fixed daterange and summary bugs

Log in or register to post comments

Comment #18

Kyiv, Ukraine

commented 28 December 2018 at 12:58

Status	File	Size
new	implement_translation_fields_preview_17.patch	25.88 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_16.patch	20.96 KB

Fixed more bugs with summary + improved inline help for image fields

Log in or register to post comments

Comment #19

Kyiv, Ukraine

commented 29 December 2018 at 10:19

Status	File	Size
new	implement_translation_fields_preview_18.patch	25.99 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_17.patch	25.88 KB

Small tweaks for summary sub-field

Log in or register to post comments

Comment #20

Kyiv, Ukraine

commented 6 January 2019 at 01:50

Status	File	Size
new	implement_translation_fields_preview_19.patch	27.23 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_18.patch	25.99 KB

Fixed alt label + make all translatable fields go inside table

Log in or register to post comments

Comment #21

Kyiv, Ukraine

commented 12 January 2019 at 16:09

Status	File	Size
new	implement_translation_fields_preview_20.patch	27.33 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	implement_translation_fields_preview_19.patch	27.23 KB

Added small fixes for the image field type

Log in or register to post comments

Comment #22

13 January 2019 at 16:14

matsbla committed 805d061 on 8.x-1.x authored by Valentine94

Issue #3016139 by Valentine94: Local Translator: Display inline...

Log in or register to post comments

Comment #23

matsbla commented 13 January 2019 at 16:14

Status:

Needs review

» Fixed

Thanks for this great work!

Log in or register to post comments

Comment #24

27 January 2019 at 16:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #25

matsbla commented 6 February 2019 at 21:53

I've reverted this so we can move it into separate project, and then later integrate it again:
https://www.drupal.org/sandbox/matsbla/3028221

Log in or register to post comments