Feature Request: Cancel your account as a collapsible field to improved user accessibility

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

StatusFileSize
new1.85 KB

please find patch for collapsible field for 'cancel account '

hardikpandya’s picture

Status: Active » Needs review
bramdriesen’s picture

Status: Needs review » Reviewed & tested by the community

Code wise seems okay.

andrew_tspkh’s picture

Version: 8.x-1.0 » 8.x-1.x-dev

Hi there
@BramDriesen it would be nice if you attach a screenshot with a fieldset, And the result of deleting the user account using this fildset. Thanks a lot!

bramdriesen’s picture

There is already an image attached :)

andrew_tspkh’s picture

But you put RTBC, so you have to show that it works fine. That attached screenshot is from @xaiwant.

bramdriesen’s picture

Since when is it mandatory to attach an image or show that something is working? Meaning someone put it on RTBC means that he/she tested and reviewed the code and marked it as ok. (Doesn't mean that the maintainer has to accept it though since there are some cases that you might want to reject it, e.g. wrong approach, out of scope etc).

I already destroyed the environment to test, and I'm not planning to boot a new one just for a screenshot...

If you're that willing to see a screenshot, put it back to needs review.

andrew_tspkh’s picture

@BramDriesen, ok I understood your point of view. Thanks for rewriting.

andrew_tspkh’s picture

Status: Reviewed & tested by the community » Needs work

Thank you @xaiwant for improvement. But I noticed some issues in your patch:

  • Please use short array syntax to be in case with Drupal 8 best practices;
  • Please use translate method from class ($this->t()) instead of t()

Could you fix them?

patelmayank7552’s picture

StatusFileSize
new1.85 KB

Hi @andrew_tspkh,

As instructed, I have made the changes in patch for improvement:

  • Please use short array syntax to be in case with Drupal 8 best practices; Done
  • Please use translate method from class ($this->t()) instead of t() : Done

cancel_aacount-3016062-11.patch please review.

patelmayank7552’s picture

Status: Needs work » Needs review
bramdriesen’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new60.9 KB

Tested again and works fine. (I indeed missed the two coding standard fixes you noticed)

With screenshot this time ;)

After clicking cancel the account is correctly canceled.

  • patelmayank7552 authored c7287b0 on 8.x-1.x
    Issue #3016062 by xaiwant, patelmayank7552, BramDriesen, andrew_tspkh,...
andrew_tspkh’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x-1.x branch.
Thanks to all for contributing.

patelmayank7552’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.