Closed (fixed)
Project:
Cancel Account Separate Form
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Nov 2018 at 10:35 UTC
Updated:
13 Dec 2018 at 09:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
xaiwant commentedplease find patch for collapsible field for 'cancel account '
Comment #3
hardikpandya commentedComment #4
bramdriesenCode wise seems okay.
Comment #5
andrew_tspkhHi there
@BramDriesen it would be nice if you attach a screenshot with a fieldset, And the result of deleting the user account using this fildset. Thanks a lot!
Comment #6
bramdriesenThere is already an image attached :)
Comment #7
andrew_tspkhBut you put RTBC, so you have to show that it works fine. That attached screenshot is from @xaiwant.
Comment #8
bramdriesenSince when is it mandatory to attach an image or show that something is working? Meaning someone put it on RTBC means that he/she tested and reviewed the code and marked it as ok. (Doesn't mean that the maintainer has to accept it though since there are some cases that you might want to reject it, e.g. wrong approach, out of scope etc).
I already destroyed the environment to test, and I'm not planning to boot a new one just for a screenshot...
If you're that willing to see a screenshot, put it back to needs review.
Comment #9
andrew_tspkh@BramDriesen, ok I understood your point of view. Thanks for rewriting.
Comment #10
andrew_tspkhThank you @xaiwant for improvement. But I noticed some issues in your patch:
Could you fix them?
Comment #11
patelmayank7552 commentedHi @andrew_tspkh,
As instructed, I have made the changes in patch for improvement:
cancel_aacount-3016062-11.patch please review.
Comment #12
patelmayank7552 commentedComment #13
bramdriesenTested again and works fine. (I indeed missed the two coding standard fixes you noticed)
With screenshot this time ;)
After clicking cancel the account is correctly canceled.
Comment #15
andrew_tspkhCommitted to 8.x-1.x branch.
Thanks to all for contributing.
Comment #16
patelmayank7552 commented