Problem/Motivation

#2807785: Move global constants from *.module files into interfaces deprecated a bunch of constants but it did not actually replace their usage. We should do this. This issue handles USERNAME_MAX_LENGTH, USER_REGISTER_ADMINISTRATORS_ONLY, USER_REGISTER_VISITORS and USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL. This is a bug because we've deprecated something but we've not completed the task.

Proposed resolution

Use UserInterface::USERNAME_MAX_LENGTH, UserInterface::REGISTER_ADMINISTRATORS_ONLY, UserInterface::REGISTER_VISITORS and UserInterface::REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL instead.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 3015752-6.patch29.89 KBbnjmnm
#3 3015752-3.patch29.46 KBalexpott
#3 2-3-interdiff.txt990 bytesalexpott
#2 3015752-2.patch29.07 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3015752-2.patch29.07 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-3-interdiff.txt990 bytes
new 3015752-3.patch29.46 KB

Missed some use statements.

Status: Needs review » Needs work

The last submitted patch, 3: 3015752-3.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

This failed due to a random fail - see #3015802: Random fail in \Drupal\Tests\Core\Transliteration\PhpTransliterationTest - retesting.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new 3015752-6.patch29.89 KB

Needed reroll

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

Reroll was simple enough that I can also review. I confirmed there were no additional uses of the deprecated constants added since the #3 patch was written, and everything else looks solid.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed d101b4f and pushed to 8.7.x. Thanks!

  • catch committed 3cc8a61 on 8.7.x 
    Issue #3015752 by alexpott, bnjmnm: Properly deprecate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.