When a booking takes more than (default 2) seconds to complete, the complete args array is written to the logs. This includes personal data of the person who books the appointment. That is not desirable.

CommentFileSizeAuthor
#5 interdiff-3-5.txt4.02 KBpaulvandenburg
#5 privacy-sensitive-data-in-log-3015572-5.patch9.04 KBpaulvandenburg
#4 privacy-sensitive-data-in-log-3015562-3.patch712 bytesralphvdhoudt
#2 privacy-sensitive-data-in-log-3015562-2.patch712 bytesjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new privacy-sensitive-data-in-log-3015562-2.patch712 bytes

This patch removes the args array from the result, and makes the log message better so you know why the message was thrown.

joshahubbers’s picture

joshahubbers commented
Status: Active » Needs review
ralphvdhoudt’s picture

ralphvdhoudt commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new privacy-sensitive-data-in-log-3015562-3.patch712 bytes

Confirmed that the patch removes the privacy related information

Added a reroll against the latest dev

paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new privacy-sensitive-data-in-log-3015572-5.patch9.04 KB
new interdiff-3-5.txt4.02 KB

Already looking good, but I found some more privacy sensitive fields in watchdogs.

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community

Accidentally uploaded the patch to the wrong issue, it was intended for the very similar #3015572: Logs can contain privacy sensitive information when a call takes too long.

Please follow the Drupal standards surrounding patch names: https://www.drupal.org/patch/submit#patch_naming

[project_name]-[short-description]-[issue-number]-[comment-number]-[drupal-version].patch

  • paulvandenburg committed 2af4b3d on 7.x-1.x 
    Issue #3015562 by JoshaHubbers, ralphvdhoudt: Logs contain privacy...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.