Problem/Motivation

Under heavy load, if someone spins up a new web head, or multiples, the asset creation of js and css can lead to a variable set stampede.

Proposed resolution

Use locking

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 DRUPAL-CORE-fix-cache-stampede-3015333.patch1.45 KBheddn

Comments

heddn created an issue. See original summary.

heddn credited fabian.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new DRUPAL-CORE-fix-cache-stampede-3015333.patch1.45 KB
fabianx’s picture

fabianx commented
Status: Active » Reviewed & tested by the community

Looks great, need to check though id this bug is present in D8 as well. It could be that this is the case.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/includes/common.inc
@@ -5058,6 +5057,24 @@ function drupal_add_tabledrag($table_id, $action, $relationship, $group, $subgro
+function _drupal_update_assets_map_with_lock($name, $key, $value) {

Nit: missing some function docs.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.