When I run tests I get fails. I think these tests don't work correctly.

CommentFileSizeAuthor
#6 3015107-6-fix_tests_fails.patch751 bytestim berners lee
#3 fix.png144.47 KBtim berners lee
#3 3015107-3-fix_tests_fails.patch912 bytestim berners lee
issue.png167.47 KBtim berners lee

Comments

Andrew Rymar created an issue. See original summary.

tim berners lee’s picture

tim berners lee commented
Issue summary: View changes
tim berners lee’s picture

tim berners lee commented
StatusFileSize
new 3015107-3-fix_tests_fails.patch912 bytes
new fix.png144.47 KB

It doesn't have permissions to create fields.
This patch should fix this fails.

b_man’s picture

b_man
he/him
Location California, USA
commented
romixua’s picture

romixua
Location 🇺🇦 lviv
commented

Changes look good, but here is little mistakes with coding standards. You have 2 extra spaces in each item of permissions array.
Diff should have this changes:

$admin_user = $this->drupalCreateUser(array(
'access content',
'administer content types',
+ 'administer fields',
'create ' . $this->type . ' content',
));
$this->drupalLogin($admin_user);

tim berners lee’s picture

tim berners lee commented
StatusFileSize
new 3015107-6-fix_tests_fails.patch751 bytes

Thank you, I corrected these mistakes.

alex_optim’s picture

alex_optim
Location Tallinn
commented

Looks good.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed ef8a162 on 7.x-1.x authored by Andrew Rymar 
    Issue #3015107 by Andrew Rymar, B_man, Romixua, alex_optim, pifagor:...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.