Thank you for releasing a new tagged release to pick up the various php 7.2 compatibility fixes of recent months.

Regarding #2742913: Warning and notice from line 247

A patch at #2742913-5: Warning and notice from line 247 was committed, and the issue marked as Closed (Fixed).

Subsequently, another problem was found, caused by fixing it in that way, resulting in a better patch at #2742913-11: Warning and notice from line 247

I had manually applied that patch to my site, and it worked. Having downloaded 7.x-3.8, I checked that patch would suggest reversal if I tried to apply that same patch, but to my surprise it didn't. So I then noticed what I'd missed before - because #2742913: Warning and notice from line 247 was never reopened, the patch at #2742913-11: Warning and notice from line 247 was never committed.

CommentFileSizeAuthor
#8 context-n3014980-7.patch1.12 KBdamienmckenna
#8 context-n3014980-7.interdiff.txt988 bytesdamienmckenna
#6 context-3014980-5.patch1.11 KBjamesoakley
#4 context-3014980-3.patch1.06 KBjamesoakley
#2 context-3014980.patch1.06 KBjamesoakley

Comments

JamesOakley created an issue. See original summary.

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
StatusFileSize
new context-3014980.patch1.06 KB

Attached is the patch you get if you start with the context.module file from the latest tagged release, apply patch 5 in reverse and then apply patch 11. So applying this to the current state will get you, in one move, to where you'd need to be if you'd run patch 11 instead.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: context-3014980.patch, failed testing. View results

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs work » Needs review
StatusFileSize
new context-3014980-3.patch1.06 KB

Wrongly formatted patch file header. Try again

Status: Needs review » Needs work

The last submitted patch, 4: context-3014980-3.patch, failed testing. View results

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs work » Needs review
StatusFileSize
new context-3014980-5.patch1.11 KB

Alright, I give up: I'll use "git diff" instead of diff-utils diff.

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs review » Reviewed & tested by the community

OK, now the test suite can actually parse the patch file, it's passed. Given this is nothing more than a re-roll of a patch in the related issue which has been reviewed and found to work, I'll set this back to RTBC.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: -PHP 7.2 (duplicate) +PHP 7.2
StatusFileSize
new context-n3014980-7.interdiff.txt988 bytes
new context-n3014980-7.patch1.12 KB

A minor tweak to add a period at the end of the sentence :)

A small reminder - you shouldn't RTBC your own patch, please leave it for others to review.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3010893: Release plan for Context 7.x-3.8
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3010893: Release plan for Context 7.x-3.8 » #3016541: Plan for Context 7.x-3.9

nedjo credited Andrey Inkin.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Crediting Andrey Inkin for the patch at #2742913-11: Warning and notice from line 247.

  • nedjo committed cb91e28 on 7.x-3.x authored by Andrey Inkin 
    Issue #3014980 by JamesOakley, DamienMcKenna, Andrey Inkin: Warning and...
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed
nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for catching this and pointing to the fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.