Problem/Motivation

Currently in bartik.theme, the description above the "bartik_preprocess_page_title" hook preprocess function is:

Implements hook_preprocess_HOOK() for page templates.

This description is not accurate. Because it is not the "bartik_preprocess_page" hook that is used here but "bartik_preprocess_page_title". So it concerns the "page title" template and not the page template.

Proposed resolution

Instead, the description should be:

Implements hook_preprocess_HOOK() for "page title" templates.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DavidPetit created an issue. See original summary.

DavidPetit’s picture

DavidPetit’s picture

apaderno’s picture

Status: Active » Needs review
Issue tags: -description +Novice

I would rather write Implements hook_preprocess_HOOK() for page title templates. or Implements hook_preprocess_HOOK() for page-title templates. (The second is better, IMO.)

brathbone’s picture

This patch implements the wording change requested in #4.

deepakkumar14’s picture

Status: Needs review » Reviewed & tested by the community

I have applied the patch in #5 and its applied successfully.
It change the comment "Implements hook_preprocess_HOOK() for page templates" to "Implements hook_preprocess_HOOK() for page-title templates" in bartik.theme file.

apaderno’s picture

Actually, the comment given for shortcut_preprocess_page_title() is the following.

Implements hook_preprocess_HOOK() for page title templates.

The same comment should be given for bartik_preprocess_page_title().

apaderno’s picture

Priority: Minor » Normal
Status: Reviewed & tested by the community » Needs review
FileSize
522 bytes
johnny_aroza’s picture

Status: Needs review » Reviewed & tested by the community

checked patch applies properly.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 688b2888d2 to 8.7.x and 6a0e4e0ca6 to 8.6.x. Thanks!

  • alexpott committed 688b288 on 8.7.x
    Issue #3014415 by brathbone, DavidPetit, kiamlaluno: Replace "page" by "...

  • alexpott committed 6a0e4e0 on 8.6.x
    Issue #3014415 by brathbone, DavidPetit, kiamlaluno: Replace "page" by "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.