Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Currently in bartik.theme, the description above the "bartik_preprocess_page_title" hook preprocess function is:
Implements hook_preprocess_HOOK() for page templates.
This description is not accurate. Because it is not the "bartik_preprocess_page" hook that is used here but "bartik_preprocess_page_title". So it concerns the "page title" template and not the page template.
Proposed resolution
Instead, the description should be:
Implements hook_preprocess_HOOK() for "page title" templates.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | fix-hook-comment-3014415-8.patch | 522 bytes | avpaderno |
| #5 | interdiff.3014415.2-5.txt | 530 bytes | brathbone |
| #5 | bartik_description_hook_page_title-3014415-5.patch | 522 bytes | brathbone |
| #2 | bartik_description_hook_page_title-3014415-1.patch | 524 bytes | davidpetit |
Comments
Comment #2
davidpetit commentedComment #3
davidpetit commentedComment #4
avpadernoI would rather write Implements hook_preprocess_HOOK() for page title templates. or Implements hook_preprocess_HOOK() for page-title templates. (The second is better, IMO.)
Comment #5
brathbone commentedThis patch implements the wording change requested in #4.
Comment #6
deepakkumar14 commentedI have applied the patch in #5 and its applied successfully.
It change the comment "Implements hook_preprocess_HOOK() for page templates" to "Implements hook_preprocess_HOOK() for page-title templates" in bartik.theme file.
Comment #7
avpadernoActually, the comment given for
shortcut_preprocess_page_title()is the following.The same comment should be given for
bartik_preprocess_page_title().Comment #8
avpadernoComment #9
johnny_aroza commentedchecked patch applies properly.
Comment #10
alexpottCommitted and pushed 688b2888d2 to 8.7.x and 6a0e4e0ca6 to 8.6.x. Thanks!