The *.libraries.yml file is missing a lot of metadata about the external JS files and the JS is not marked as external nor minified.

CommentFileSizeAuthor
#2 3014398-braintree_cashier-libraries-definition-missing-metadata.patch686 bytesperignon

Comments

Perignon created an issue. See original summary.

perignon’s picture

perignon commented
StatusFileSize
new 3014398-braintree_cashier-libraries-definition-missing-metadata.patch686 bytes

Attached is a patch to add the missing metadata

caldenjacobs’s picture

caldenjacobs commented
Status: Active » Reviewed & tested by the community
perignon’s picture

perignon commented

Thanks for reviewing!

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented

Thanks! I'll be able to commit this next week when my Macbook is finished having it's keyboard replaced.

perignon’s picture

perignon commented

I just put new batteries in mine! That was fun. Took me about 2 hours to do it. Keyboard was the only thing remaining in the case.

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented
Status: Reviewed & tested by the community » Fixed

Things are so integrated on Macs now that a new keyboard comes with a new... battery!

Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.