The Server Notice module is geared to prevent content creation or updates on the wrong server by advising the user which server they are currently on through way of a viewport border along with optional message.

The server notice list along with a displayed server notice (note the colour field is currently empty, this is listed as a known issue on the project page):

Server notice demonstration

Project link

https://www.drupal.org/project/server_notice

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/server_notice.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-server_notice....

CommentFileSizeAuthor
Screen Shot 2018-11-16 at 1.30.20 PM.png200.58 KBbeccaneer

Comments

beccaneer created an issue. See original summary.

manish34jain’s picture

manish34jain commented

Hello beccaneer,

Please run automated review and check the errors.

Here is the report. https://pareview.sh/pareview/https-git.drupal.org-project-server_notice.git

Thanks

manish34jain’s picture

manish34jain commented

Hello beccaneer

When i install this then it's showing below errors

TypeError: Argument 2 passed to server_notice_help() must be an instance of RouteMatchInterface, instance of Drupal\Core\Routing\CurrentRouteMatch given in server_notice_help() (line 13 of /modules/server_notice/server_notice.module)

Thanks

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

I am changing status basing on the previous comments.

beccaneer’s picture

beccaneer commented
Status: Needs work » Needs review

The above issues have been fixed, thanks everyone for your feedback.

There is still a git-related error that comes up in the Drupal review tool, due to my commit message being insufficient but I would prefer to not change this because GitHub recommends to not change commit messages after they have already been pushed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
beccaneer’s picture

beccaneer commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.