PayPal is branded as PayPal, not Paypal. The second P has to be capital. The required changes need to be made in the code.

CommentFileSizeAuthor
#7 social_auth_paypal-changed-name-3013252-7.patch18.31 KBneel24
#5 social_auth_paypal-updated-3013252-5.patch26.15 KBneel24
#4 social_auth_paypal-updated-3013252-4.patch24.92 KBneel24
#2 social-auth-paypal-3013252-2.patch5.6 KBSnehal Brahmbhatt

Comments

ragasirtahk created an issue. See original summary.

Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Active » Needs review
StatusFileSize
new social-auth-paypal-3013252-2.patch5.6 KB

@ragasirtahk, Please find all the typo corrections in the attached patch. Hope this helps you. Thanks!..

ragasirtahk’s picture

ragasirtahk commented
Status: Needs review » Needs work

The classes should also be renamed to PayPal. See https://www.drupal.org/project/social_auth_github/issues/2988841 for reference

neel24’s picture

neel24 commented
Status: Needs work » Needs review
StatusFileSize
new social_auth_paypal-updated-3013252-4.patch24.92 KB

Created a patch which applies the required changes to all of the files.

neel24’s picture

neel24 commented
StatusFileSize
new social_auth_paypal-updated-3013252-5.patch26.15 KB

Sorry, forgot to change something. This is the correct patch.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Seems to be ok :)

neel24’s picture

neel24 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new social_auth_paypal-changed-name-3013252-7.patch18.31 KB

I'm attaching a new patch. Some file names had to be renamed as well.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

  • gvso committed 2ffb94d on 8.x-2.x 
    Issue #3013252 by neel24, dev20.addweb, ragasirtahk, BramDriesen: "...
gvso’s picture

gvso
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

Make some small changes since the module stopped working after applying the patch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.