The gulp version in package.json is mentioned as
"gulp": "github:gulpjs/gulp#4.0",
Which throws the below error,
npm ERR! git rev-list -n1 4.0: fatal: ambiguous argument '4.0': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 4.0: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 4.0: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 4.0:
Seems like this should like this,
"gulp": "github:gulpjs/gulp#v4.0.0"
As there is no more a 4.0 tag https://github.com/gulpjs/gulp
Attaching a simple patch for this.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3013084-gulp-5.patch | 129.46 KB | swarad07 |
| #2 | 3013084-2.patch | 402 bytes | swarad07 |
Comments
Comment #2
swarad07Comment #3
skippednote commentedHey Swarad.
Thank you for pointing the issue and contributing a patch.
A few nits:
- Can you add package-lock.json to the diff as well?
- I'm not able to apply the patch against the latest 8.x-1.x-dev
Thanks
Comment #4
swarad07Hey skippednote,
I did not see the dev branch, used the 8.x-1.x branch. Let me correct that.
Comment #5
swarad07Patch against 8.x-1.x-dev branch, steps done,
- Corrected the GitHub version string for gulp.
- Ran npm install to get updated package-lock.json.
Comment #6
skippednote commented