Module name should capitalized and description end with a dot per coding standard.
I suggest also to add a dependency on user module as this module deals with user delegation.

CommentFileSizeAuthor
#15 Screenshot 2020-08-31 at 3.46.43 PM.png100.43 KBmeghasharma
#12 create_user_permission_3012812-12.patch547 bytesadityasingh
#2 Update_dependencies_format_in_info.yml_3012812-2.patch509 byteschipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3012812-2.patch509 bytes

Here is the patch. Please review.

Status: Needs review » Needs work

The last submitted patch, 2: Update_dependencies_format_in_info.yml_3012812-2.patch, failed testing. View results

chipway’s picture

chipway commented
Status: Needs work » Needs review

Unrelated test failure. Please review manually.

Status: Needs review » Needs work

The last submitted patch, 2: Update_dependencies_format_in_info.yml_3012812-2.patch, failed testing. View results

chipway’s picture

chipway commented
Status: Needs work » Needs review

Unrelated test failure. Please review manually.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Version: 8.x-1.x-dev » 2.x-dev
Assigned: Unassigned » eiriksm
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Title: Coding standards an dependencies » Coding standards and dependencies
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Novice

This does not apply anymore

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Assigned: eiriksm » Unassigned
adityasingh’s picture

adityasingh commented
Assigned: Unassigned » adityasingh
adityasingh’s picture

adityasingh commented
Assigned: adityasingh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new create_user_permission_3012812-12.patch547 bytes

Hi @eiriksm
Updated patch applied cleanly please review.

Checking patch create_user_permission.info.yml...
Applied patch create_user_permission.info.yml cleanly.
meghasharma’s picture

meghasharma commented
Assigned: Unassigned » meghasharma
meghasharma’s picture

meghasharma commented
Assigned: meghasharma » Unassigned
Status: Needs review » Reviewed & tested by the community

it looks good to me..
Patch applied create_user_permission.info.yml cleanly.

meghasharma’s picture

meghasharma commented
StatusFileSize
new Screenshot 2020-08-31 at 3.46.43 PM.png100.43 KB
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Assigned: Unassigned » eiriksm

  • eiriksm committed 97f3078 on 2.x authored by adityasingh 
    Issue #3012812 by chipway, adityasingh, meghasharma, eiriksm: Coding...
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Assigned: eiriksm » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.