While evaluating this module, while it has a readme, I noticed the readme could use some helpful links and configurations.
According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

Patch to follow, thanks!

CommentFileSizeAuthor
#6 custom_add_content-3012360-6.patch2.97 KBSnehal Brahmbhatt
#3 custom_add_content-readme-3012360-3.patch2.78 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Title: README missing requirements » README configs and formatting
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new custom_add_content-readme-3012360-3.patch2.78 KB

I updated the readme to include some recommended modules. Thanks!!

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Reviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards. Everything looks good. Patch applied.
Marking as RTBCed.
Thank you for working on module!

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Needs work

I'm sorry but in my computer I had a small change on README file (1 commit ahead of origin) so your patch doesn't apply. Please, could you make a new one? Thanks!

Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Needs work » Needs review
StatusFileSize
new custom_add_content-3012360-6.patch2.97 KB

@rcodina, Please find my patch for the same I Created it for Readme coding standards. let me know if you still face the same issue. Thanks!..

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Patch applied locally. Marking rtbc. Thanks for the re-roll!

  • rcodina committed 8d6a430 on 8.x-1.x authored by snehal.addweb 
    Issue #3012360 by volkswagenchick, snehal.addweb, alonaoneill, rcodina:...
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Thanks to everyone!

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Fixed » Closed (fixed)