Problem/Motivation

Follow-up of #2715859: ImageWidget::validateRequiredFields() produces an error message if an image field is hidden with hook_entity_field_access().

When testing that, I found that depending on the cardinality, an image/file widget behaves differently when it is hidden.

1 or unlimited: The ManagedFile validation is triggered which doesn't know anything about access or not and then the validation always fails.

Anything else: FileWidget sets its own element validation callback, replacing the default value, which skips the ManagedFile validation but doesn't fail if the field is hidden.

Proposed resolution

Always skip the form-level validation, rely on the constraints? One problem is that we get the usual cryptic validation message then instead of the more readable one.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Berdir created an issue. See original summary.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

aaronbauman’s picture

aaronbauman
he/him
commented

Proposed resolution
Always skip the form-level validation, rely on the constraints? One problem is that we get the usual cryptic validation message then instead of the more readable one.

I'm not totally clear on the implications, but this seems like a big change.
Seems like a simpler change would be to always use the same validation scheme - ManagedFile or FileWidget, i'm not sure which - regardless of cardinality.

Am I missing something?

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

luke.stewart’s picture

luke.stewart commented
Issue tags: +Bug Smash Initiative
luke.stewart’s picture

luke.stewart commented
Status: Active » Closed (cannot reproduce)
Issue tags: +DrupalSouth 2026

This needs some clearer steps to reproduce.

I just attempted on D12.

Created two fields Type File, File. Cardinality 1 and Cardinality 2. set both to not display on form display (I think this is what you mean by hidden?) but suspect I'm missing something here.

Given this has been sitting with no change since 2019. I think if this doesn't get any update in 3 months it can probably be closed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

luke.stewart’s picture

luke.stewart commented
Status: Closed (cannot reproduce) » Postponed (maintainer needs more info)