This module adds the Google Optimize page-hiding snippet to pages.
See https://developers.google.com/optimize/#the_page-hiding_snippet_code for Google's documentation.
There is a D7 module for Google Optimize https://www.drupal.org/project/google_optimize_hide_page but no D8 version. I have tried to contact the maintainer of the D7 module.

Project link

https://www.drupal.org/project/d8_google_optimize_hide_page

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/d8_google_optimize_hide_page.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-d8_google_opti...

Comments

webfaqtory created an issue. See original summary.

webfaqtory’s picture

Issue summary: View changes
avpaderno’s picture

Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

avpaderno’s picture

Status: Needs review » Needs work

Please fix the formatting issues reported from PAReview and use dependency injection instead of using t().

webfaqtory’s picture

Completed all issues reported by PAReview. A much more comprehensive code checker than "phpcs --standard=Drupal"

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs work » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

avpaderno’s picture

As side note, the commits aren't linked to your account because the email used for the commits is not registered on drupal.org. If you want the commits to be associated with your account, you need to change the email address used from Git or add that email address on https://www.drupal.org/user/241985/edit/email-addresses.

webfaqtory’s picture

Assigned: avpaderno » Unassigned
Status: Fixed » Needs work

Many thanks, updated email list.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.