Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Nov 2018 at 18:21 UTC
Updated:
22 Nov 2018 at 14:24 UTC
Jump to comment: Most recent
Comments
Comment #2
webfaqtory commentedComment #3
avpadernoThank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.
Next, the reviewers will check the project code, and report here what needs to be changed.
Comment #4
avpadernoPlease fix the formatting issues reported from PAReview and use dependency injection instead of using
t().Comment #5
webfaqtory commentedCompleted all issues reported by PAReview. A much more comprehensive code checker than "phpcs --standard=Drupal"
Comment #6
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #7
avpadernoAs side note, the commits aren't linked to your account because the email used for the commits is not registered on drupal.org. If you want the commits to be associated with your account, you need to change the email address used from Git or add that email address on https://www.drupal.org/user/241985/edit/email-addresses.
Comment #8
webfaqtory commentedMany thanks, updated email list.
Comment #9
avpaderno