[D8] Voting Rules

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

I will make a manual review this evening.

/**
 * Implements hook_votingapi_op().
 */
function _voting_rules_votingapi_op($votes, $op) {
  foreach ($votes as $vote) {
    $entity = voting_rules_load_entity($vote['entity_type'], $vote['entity_id']);

    if ($entity) {
      if (in_array($vote['entity_type'], array_keys(voting_rules_get_types()))) {
        rules_invoke_event('voting_rules_' . $op . '_' . $vote['entity_type'], $vote, $entity);
      }
      else {
        rules_invoke_event('voting_rules_' . $op . '_entity', $vote, $entity);
      }
    }
  }
}

Hook implementations don't have a name that starts with an underscore. Either that is not a hook implementation, or the function name is wrong and it should not start with an underscore.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Keep in mind that, since the project is new, you need to wait 10 days before opting into security coverage.