Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
1 Nov 2018 at 08:31 UTC
Updated:
25 Nov 2018 at 17:09 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.
Next, the reviewers will check the project code, and report here what needs to be changed.
Comment #3
avpadernoThe code is too simple to give the vetted role, though. It can be used to opt into security advisory coverage only for that project.
Comment #4
kumar_kundan commentedComment #5
kumar_kundan commentedComment #6
avpadernoComment #7
kumar_kundan commentedCode is now passed by coder module.
Comment #8
kumar_kundan commentedComment #9
kumar_kundan commentedComment #10
avpadernoComment #11
avpadernoThe functions a module defines need to have their names prefixed by the module name. In this case, a function like
check_user_has_role()should be callednode_matrix_check_user_has_role(). (I would rather call itnode_matrix_check_is_administrator()since that is the purpose of the function.)The function code can also be reduced to two lines, since
in_array()already returns a Boolean value.Comment #12
kumar_kundan commentedComment #13
kumar_kundan commentedFixed the changes suggested.
Comment #14
kumar_kundan commentedMade suggested changes.
Comment #15
kumar_kundan commentedComment #16
kumar_kundan commentedComment #17
avpadernoComment #18
avpadernoThe project status cannot be changed if not after 10 days it was created. (The code implemented for security coverage opt in doesn't allow to change status earlier, not even to webmasters.)
I am changing status for this reason.
Comment #19
kumar_kundan commentedHi @kiamlaluno I am very new to contribute. Please change the status to need review.
Thanks
Comment #20
avpadernoSee my previous comment.
Comment #21
avpadernoThank you for your contribution! I am going to update the project to opt into security coverage.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #22
kumar_kundan commentedThank you.