This module provides a new tab 'Matrix' next to edit, it provide information of accessed IP address and time. It would be helpful to understand user behavior to node and it information will be helpful. This is very slick module and useful.

Project link

https://www.drupal.org/project/node_matrix

Git instructions

git clone --branch master https://git.drupal.org/project/node_matrix.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-node_matrix.git

Comments

kumar_kundan created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

avpaderno’s picture

The code is too simple to give the vetted role, though. It can be used to opt into security advisory coverage only for that project.

kumar_kundan’s picture

Assigned: Unassigned » kumar_kundan
kumar_kundan’s picture

Assigned: kumar_kundan » Unassigned
avpaderno’s picture

kumar_kundan’s picture

Assigned: Unassigned » kumar_kundan

Code is now passed by coder module.

kumar_kundan’s picture

Assigned: kumar_kundan » Unassigned
Issue summary: View changes
kumar_kundan’s picture

avpaderno’s picture

Issue summary: View changes
avpaderno’s picture

Status: Needs review » Needs work

The functions a module defines need to have their names prefixed by the module name. In this case, a function like check_user_has_role() should be called node_matrix_check_user_has_role(). (I would rather call it node_matrix_check_is_administrator() since that is the purpose of the function.)

The function code can also be reduced to two lines, since in_array() already returns a Boolean value.

function check_user_has_role() {
  global $user;
  return in_array('administrator', $user->roles);
}
kumar_kundan’s picture

Assigned: Unassigned » kumar_kundan
kumar_kundan’s picture

Status: Needs work » Fixed

Fixed the changes suggested.

kumar_kundan’s picture

Status: Fixed » Closed (fixed)

Made suggested changes.

kumar_kundan’s picture

Assigned: kumar_kundan » Unassigned
kumar_kundan’s picture

avpaderno’s picture

Status: Closed (fixed) » Needs review
avpaderno’s picture

Status: Needs review » Postponed

The project status cannot be changed if not after 10 days it was created. (The code implemented for security coverage opt in doesn't allow to change status earlier, not even to webmasters.)

I am changing status for this reason.

kumar_kundan’s picture

Hi @kiamlaluno I am very new to contribute. Please change the status to need review.

Thanks

avpaderno’s picture

See my previous comment.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Postponed » Fixed

Thank you for your contribution! I am going to update the project to opt into security coverage.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

kumar_kundan’s picture

Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.