ive installed this module added a new modal page, cleared the cache both in UI and drush cr and its not doing anything at all. ive tried pages and parameters.

Tested with Drupal 8.6

thanks

CommentFileSizeAuthor
#11 module-not-work-3009324.png80.93 KBthalles

Comments

laurencefass created an issue. See original summary.

Syntapse’s picture

Title: module has no effect with Drupal 8.6 » module not working at all with Drupal 8.6
renatog’s picture

Version: 8.x-3.x-dev » 8.x-2.1
Priority: Major » Normal
Status: Active » Needs review

Hello Lauren.

Can you use the version: 8.x-2.1, please?!

https://ftp.drupal.org/files/projects/modal_page-8.x-2.1.zip

This version is stable and works good for Drupal 8.6+

Any question please comment, okay?!

Best,

renatog’s picture

@laurencefass; after your testes tell me if version: 8.x-2.1 works good for you.

Good Work and Good Week.

Thank you very much.

Best,

Syntapse’s picture

i will retest in a few days. i had to uninstall because it caused some admin styling problems which went after uninstall of the module. hope 2.1 will fix. thanks.

thalles’s picture

Category: Bug report » Support request
Egmund’s picture

I can attest that ver 8.2.1 does not work w. D8.6.3 - except for one site (out of 3). It must be a conflict with other modules or themes (I guess). No log messages either.

Egmund’s picture

On further thoughts: The one site working is an older install, so Drupal has been upgraded several times, whereas the two non-working sites are fresh installs. Maybe (therefore) it is in the settings or htaccess files, which I do not upgrade/update.

Egmund’s picture

Update:
I installed D8.6.3 with an old (march 2016) default settings.php file and module works fine in Bartic.
However installing bootstrap-based themes interfere with the module so that the modal pop-up show wrong text etc and will lock up the site.

In other words: There are conflicts with other modal modules or code/script. The module does not function with the new settings.php file.

Egmund’s picture

Further testing.
With bootstrap javascript modal disabled (bootstrap3 theme) module works, but does not look completely correct.

thalles’s picture

Issue summary: View changes
Issue tags: +ciandt-contrib, +#ciandt-contrib
StatusFileSize
new80.93 KB

Please, try the new release and in case of theme bootstrap disable load JS Bootstrap (bootstrap.min.js).

Look:

Egmund’s picture

Sorry, the update crashes my site with:
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'base.body__value' in 'field list': SELECT base.id AS id, base.uuid AS uuid, base.title AS title, base.body__value AS body__value, base.body__format AS body__format, base.type AS type, base.pages AS pages, base.parameters AS parameters, base.ok_label_button AS ok_label_button, base.langcode AS langcode, base.created AS created, base.changed AS changed FROM {modal} base WHERE base.id IN (:db_condition_placeholder_0); Array ( [:db_condition_placeholder_0] => 1 ) i Drupal\Core\Entity\Sql\SqlContentEntityStorage->getFromStorage() (linje 388 af /home2/rudbecks/d8b.sensistop.dk/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

I was able to get the earlier ver. to work by overriding CSS & disablind bootstrap modal js.

Egmund’s picture

I tried new ver in another install w. another theme (quatar) and disabled bootstrap js as per your advice. I get 'unexpected error' when trying to go into modal-page and log gives:
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'base.body__value' in 'field list': SELECT base.id AS id, base.uuid AS uuid, base.title AS title, base.body__value AS body__value, base.body__format AS body__format, base.type AS type, base.pages AS pages, base.parameters AS parameters, base.ok_label_button AS ok_label_button, base.langcode AS langcode, base.created AS created, base.changed AS changed FROM {modal} base WHERE base.id IN (:db_condition_placeholder_0); Array ( [:db_condition_placeholder_0] => 1 ) i Drupal\Core\Entity\Sql\SqlContentEntityStorage->getFromStorage() (linje 388 af /home2/rudbecks/d8.sensistop.dk/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

thalles’s picture

Egmund, it is necessary to rebuild the entity, but I do not know if it is advisable in your case, which already has modals.

Egmund’s picture

Thank you thalles. I will try that.

Egmund’s picture

After un-installing, clearing cache & installing - errors are gone.
However; the modal popup does not show. It has an element style of 'display: none'. Where do I correct that?

Egmund’s picture

Update: If I uncheck 'do not load bottstrap - - -', then it shows. --Does not make much sense to me.

thalles’s picture

This option is for those who for some reason already loads the bootstrap js.

Example: If you use a bootstrap-based theme.

thalles’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.