When this module is enabled, settings at /admin/config/system/site-information (for stuff like Site name, Slogan, Email address, etc. are not saved. The footer message is saved, though.

I'll attach a patch it a bit, but this change in footer_message.module fixed it for me.

-  $form['actions']['submit']['#submit'][] = 'footer_message_form_system_site_information_settings_submit';
+  $form['#submit'][] = 'footer_message_form_system_site_information_settings_submit';

I don't know why the existing handler attachment didn't work. I searched the web and found examples of both, but I couldn't find any official documentation for why we should prefer one over the other.

This fix works on Drupal 8.6.2. I haven't tested it on earlier versions, and I wonder if something in core changed since this module was released.

CommentFileSizeAuthor
#3 footer_message_coding_standard_fix-3008391-3.patch556 bytespatelmayank7552
#3 2018-11-30_footer_message_after_enable_after_apply_patch.png73.81 KBpatelmayank7552
#3 2018-11-30_footer_message_after_enable_before_apply_patch.png70.11 KBpatelmayank7552
#2 footer_message-site_info_fix-1054616-1.patch484 bytesjeffam

Comments

jeffam created an issue. See original summary.

jeffam’s picture

jeffam
Primary language English
commented
StatusFileSize
new footer_message-site_info_fix-1054616-1.patch484 bytes

Here's a patch.

patelmayank7552’s picture

patelmayank7552 commented
Status: Active » Needs review
StatusFileSize
new 2018-11-30_footer_message_after_enable_before_apply_patch.png70.11 KB
new 2018-11-30_footer_message_after_enable_after_apply_patch.png73.81 KB
new footer_message_coding_standard_fix-3008391-3.patch556 bytes

Hi @jeffam and @andrew_tspkh,

I have applied the patch and checked it is allowing to save other values https://sitename/admin/config/system/site-information on this form.

And I have added the comment for submitting function called to save the settings.

Prefer the images for reference.

Creating a patch for coding standards to be followed.

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs review » Reviewed & tested by the community
andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
commented

Thank you for a patch.

  • jeffam authored 90feb4d on 8.x-1.x 
    Issue #3008391 by patelmayank7552, jeffam, andrew_tspkh: Site...
andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.