According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
and
"Capitalize the name of the module, because module names are proper nouns."
https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...
Patch to follow, thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | google_analytics_light_report-info-file-3008374-5.patch | 590 bytes | dhirendra.mishra |
| #3 | Screen Shot 2018-10-22 at 10.32.50 AM.png | 8.47 KB | alonaoneill |
| #2 | google_analytics_light_report-info-file-3008374-2.patch | 487 bytes | volkswagenchick |
Comments
Comment #2
volkswagenchickI uploaded a patch that cleans up the info file as per Drupal documentation guidelines. Thanks!
Comment #3
alonaoneill commentedCode looks good, the name of the module is now capitalized on the Extend page. Screenshot provided." The dependency namespacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on module!
Comment #4
dhirendra.mishra commentedNeeds to improve grammer in description. Can we do it in same ticket ?
Comment #5
dhirendra.mishra commentedHere is the updated patch for same.Thanks
Comment #8
babusaheb.vikas commentedComment #9
babusaheb.vikas commented