FILE: /var/www/html/latest/modules/lightning_api/lightning_api.module
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
140 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block templates."
-----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/tests/src/Kernel/OAuthKeyFormTest.php
--------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------
10 | ERROR | [ ] Missing short description in doc comment
24 | ERROR | [x] Missing function doc comment
41 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/tests/modules/api_tests/api_tests.install
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/lightning_api.install
-----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
60 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
101 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
106 | ERROR | [x] A unary operator statement must not be followed by a space
-----------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/src/OAuthKey.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
85 | ERROR | [ ] @throws comment must be on the next line
----------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/src/Form/OAuthKeyForm.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
13 | ERROR | [x] Missing class doc comment
29 | ERROR | [x] Data types in @param tags need to be fully namespaced
136 | ERROR | [x] Data types in @param tags need to be fully namespaced
155 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/src/LightningApiServiceProvider.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/src/RequestSubscriber.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
12 | ERROR | [x] Missing class doc comment
30 | ERROR | [ ] Parameter $translation is not described in comment
53 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/src/Exception/KeyGenerationException.php
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
5 | ERROR | [x] Missing class doc comment
7 | ERROR | [x] Missing function doc comment
-----------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/modules/api_test/tests/src/Functional/EntityCrudTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
118 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
119 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
120 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
121 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
139 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
140 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
-------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/modules/api_test/tests/src/Functional/ApiTestBase.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
34 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
42 | ERROR | [ ] Type hint "array" missing for $client_options
92 | ERROR | [ ] Type hint "array" missing for $data
100 | WARNING | [x] A comma should follow the last multiline array item. Found: 'application/vnd.api+json'
134 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/modules/api_test/tests/src/Functional/ApiTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
10 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
66 | WARNING | [x] A comma should follow the last multiline array item. Found: 'With my own two hands'
67 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
68 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
86 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
113 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/modules/api_test/api_test.install
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
4 | ERROR | [x] The second line in the file doc comment must be "@file"
----------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/modules/api_test/api_test.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------

FILE: /var/www/html/latest/modules/lightning_api/modules/api_test/README.md
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
18 | WARNING | Line exceeds 80 characters; contains 157 characters
---------------------------------------------------------------------------

Comments

deepanker_bhalla created an issue. See original summary.

deepanker_bhalla’s picture

Status: Active » Needs review
StatusFileSize
new13.87 KB

Fixed the reported issues. Kindly review.

dhirendra.mishra’s picture

Status: Needs review » Needs work

@deepanker_bhalla could you please check if this issue is created from 8.x-2.x branch!. As your patch does not get apply to same branch. Looks you created from 8.x-3.x.

daiwik.addweb’s picture

Status: Needs work » Needs review
StatusFileSize
new14.6 KB

@dhirendra.mishra, Please find my attached patch which resolves the standard errors for module version 2.x. hope this helps you now.

Thanks!.

phenaproxima’s picture

Status: Needs review » Closed (outdated)

This has been addressed internally in the time since this patch was posted, so I'm afraid I need to close this as outdated. Sorry :(