Removing deprecate drupal_set_message() from RestUIController.php file, according this https://www.drupal.org/node/2774931

CommentFileSizeAuthor
#7 remove_deprecated_drupal_set_message_points_fixed.patch5.29 KBmeickol
#5 remove_deprecated_drupal_set_message.patch5.29 KBmeickol
#2 remove_drupal_set_message.patch5.15 KBmeickol
revemo_drupal_set_message.patch2.53 KBmeickol

Comments

meickol created an issue. See original summary.

meickol’s picture

meickol
He/His
commented
StatusFileSize
new remove_drupal_set_message.patch5.15 KB

Removing drupal_set_message() from other php file and adding t() to the message parameter.
Use this patch, ignore the older one.

meickol’s picture

meickol
He/His
commented
Assigned: meickol » Unassigned
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +API-First Initiative

Thanks for doing this!

Some nitpicks, and one problem:

  1. +++ b/src/Controller/RestUIController.php
@@ -39,6 +40,13 @@ class RestUIController implements ContainerInjectionInterface {
+   * The Messenger service.

+++ b/src/Form/RestUIForm.php
@@ -54,6 +55,13 @@ class RestUIForm extends ConfigFormBase {
+   * The Messenger service.

    Nit: s/Messenger/messenger/ 

  2. +++ b/src/Controller/RestUIController.php
@@ -59,11 +68,14 @@ class RestUIController implements ContainerInjectionInterface {
+   *   The REST resource config storage.

    The messenger service. 

  3. +++ b/src/Form/RestUIForm.php
@@ -422,6 +432,7 @@ class RestUIForm extends ConfigFormBase {
     drupal_set_message($this->t('The resource has been updated.'));

    This needs to be deleted.

meickol’s picture

meickol
He/His
commented
StatusFileSize
new remove_deprecated_drupal_set_message.patch5.29 KB

Hello @Wim Leers , sorry for point 2 and 3 I fixed them, but I dont get the point 1, what this "Nit: s/Messenger/messenger/" means ?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

It means:

Substitute "Messenger" with "messenger"

i.e. the first letter should not be capitalized. (s/foo/bar/ is vim/regex syntax for replacing "foo" with "bar".)

meickol’s picture

meickol
He/His
commented
StatusFileSize
new remove_deprecated_drupal_set_message_points_fixed.patch5.29 KB

@Wim Leers thanks for your feed back! all points fixed!

meickol’s picture

meickol
He/His
commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +@deprecated

Thanks! :)

meickol’s picture

meickol
He/His
commented

@Wim Leers should we assign this to someone to get committed ? or what ? thanks :).

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

We just wait: @clemens.tolboom occasionally looks at this issue queue. This is of course not urgent, so I don't think it's a good idea to ping him.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.