In the 8.6.2/8.5.8 security release, core intentionally introduced a backwards compatibility break. A new method was added to StateTransitionValidationInterface and workflow participants has an implementation of this interface, but with no implementation.

As it stands in those releases, we don't have enough information to properly implement the new method, so the ability to fix this is contingent upon #3007716: Security update introduces breaking changes to content moderation landing in core.

Comments

kevin.dutra created an issue. See original summary.

kevin.dutra’s picture

Assigned: Unassigned » kevin.dutra
kevin.dutra’s picture

Status: Active » Needs review
StatusFileSize
new1.33 KB

Based on where the core patch is headed, here is a simple implementation.

kevin.dutra’s picture

Assigned: kevin.dutra » Unassigned
kevin.dutra’s picture

Assigned: Unassigned » kevin.dutra
Status: Needs review » Needs work

Hmm, this doesn't quite work. getValidTransitions() doesn't always correctly identify the current state of the post when validating and so it doesn't generate the correct list.

kevin.dutra’s picture

Assigned: kevin.dutra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.71 KB
new1.25 KB

Here we go, now the initial state of the entity is ensured.

Status: Needs review » Needs work

The last submitted patch, 6: security-bc-break-3007906-6.patch, failed testing. View results

  • jhedstrom committed be4fcd0 on 8.x-2.x authored by kevin.dutra
    Issue #3007906 by kevin.dutra: Core security release breaks workflow...
jhedstrom’s picture

Status: Needs work » Fixed

Since this resolves a fatal error I'm committing it. The tests that are failing appear to be new issues with core deprecations. These will be addressed in #3047489: Fix deprecations.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.