All dependencies must be prefixed by project name. Partly done. To be completed.

CommentFileSizeAuthor
#2 Update_dependencies_format_in_info.yml_3007019-2.patch1.94 KBchipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Title: All dependencies must be prefixed » All dependencies must be prefixed + end dot
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3007019-2.patch1.94 KB

Here is the patch to be comprehensive. Please review.
I also added a few missing description end dots.

Status: Needs review » Needs work

The last submitted patch, 2: Update_dependencies_format_in_info.yml_3007019-2.patch, failed testing. View results

chipway’s picture

chipway commented
Status: Needs work » Needs review

Unrelated test failure. Please review manualy.

quiron’s picture

quiron
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3032710: Tests broken for 8.x-2.x

I fixed the tests issue in the patch in #3032710

Tested both patches and the tests work fine. Also manually reviewed looks good. Moving to RTBC

  • jsacksick committed a6342c7 on 8.x-2.x authored by chipway 
    Issue #3007019 by chipway, quiron, jsacksick: All dependencies must be...
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Ok this was already fixed besides the description change and the dependency of the test module, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.