When attempting to use Language, Tour Module, and the Tour UI module there is an issue when saving or modifying the language-overview or the language-continue tips will constantly append text to the body regardless if the tips have the provided text that are being appended.

Steps to Reproduce in UI

* Download and Install Tour_UI module
* Enable Language module
* Add Language Module

Go to Tour UI config then edit the language tour. Edit the any tour tip like Adding languages and press save. Then edit the Languages tip and there should be a repeating text. It may take 1-2 times of reproducing the previous before it is noticeable.

The way to programmatically do it is to load the tips and loop through them to see the constant output:

$tour = \Drupal::entityTypeManager()->getStorage('tour')->load('language');
$tips = $tour->getTips();
foreach ($tips AS &$tip){
echo($tip->id());
echo($tip->get('body'));
}

$tips = $tour->getTips();
foreach ($tips AS &$tip){
echo ($tip->id());
echo ($tip->get('body'));
}

The biggest culprit is the language_tour_tips_alter function

CommentFileSizeAuthor
#3 3006356-language-issue_with_tours-3.patch1.4 KBsean_e_dietrich

Comments

sean_e_dietrich created an issue. See original summary.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Component: language system » language.module
sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
StatusFileSize
new 3006356-language-issue_with_tours-3.patch1.4 KB

I have applied my suggested patch which tests to see if the suggested text already exists.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Active » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue tags: +badcamp 2018

tagging for badcamp 2018

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

So just FYI tour is being considered for removal from core and moved to contrib (where hopefully we will fold in Tour UI) so not sure if adding a fix to core for something being removed will work.

But this would need tests also.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sleitner’s picture

sleitner commented
Project: Drupal core » Tour
Version: 11.x-dev » 2.0.x-dev
Component: language.module » Code

function language_tour_tips_alter() moved to Tour contrib module function tour_tour_tips_alter()

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)

Before looking into this anyone know still a problem? Tour ui is obsolete now essentially

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Not sure I'm seeing this and Tour UI is obsolete. If still a bug we can always re-open.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.