All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

It is useful for Installation profiles to work well. So sooner is better.
Hope this helps.

CommentFileSizeAuthor
#5 Update_dependencies_format_in_info.yml_3005872-5.patch1.49 KBchipway
#2 Update_dependencies_format_in_info.yml_3005872-2.patch615 byteschipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3005872-2.patch615 bytes

Here is the patch. Please review.
I also
added a missing description end dot.
capitalized a module name per coding standards.

matsbla’s picture

matsbla commented

You've added the prefix to dependencies of the test module, but I guess we also need to update the main module + the submodule?

matsbla’s picture

matsbla commented
Status: Needs review » Needs work
chipway’s picture

chipway commented
StatusFileSize
new Update_dependencies_format_in_info.yml_3005872-5.patch1.49 KB

Thanks @matsbla for review.

I added prefixes on other modules, and a dependency on drupal:field for the main one as this module provides a widget.

I also added missing description end dots and capitalized a module name per coding standards.

Here is the patch. Please review.

chipway’s picture

chipway commented
Status: Needs work » Needs review
sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Needs review » Reviewed & tested by the community

Patch applies successfully. Marking as RTBC.

  • matsbla committed 08e0b1f on 8.x-1.x authored by chipway 
    Issue #3005872 by chipway, sean_e_dietrich: All dependencies must be...
matsbla’s picture

matsbla commented

Okay, thanks for that!

matsbla’s picture

matsbla commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.