Within the hook_menu_local_tasks_alter hook when 'access moderation notes' is granted a View notes button is added, this does not currently assign a weight. I'm not sure if this is mandatory, but all other modules that I've found always assign a weight here.

The only reason this throws an issue is with modules not pre-checking for a weight, but it definitely feels like it should be defined.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andywhale created an issue. See original summary.

andy_w’s picture

Status: Needs work » Needs review
StatusFileSize
new481 bytes

Attached a patch for this. Great module by the way!

Status: Needs review » Needs work

The last submitted patch, 2: 3005555-view-notes-local-task-weight.patch, failed testing. View results

andy_w’s picture

Status: Needs work » Needs review
StatusFileSize
new390 bytes

Weight added incorrectly to local task

Status: Needs review » Needs work

The last submitted patch, 4: 3005555-view-notes-local-task-weight.patch, failed testing. View results

bluegeek9’s picture

Status: Needs work » Reviewed & tested by the community

The patch works for me. I was not able to reproduce the issue described in the summary.

  • bluegeek9 committed f3bbc2af on 8.x-1.x
    Issue #3005555 by andy_w, bluegeek9: Local link to note list but no...
bluegeek9’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.