All dependencies must be prefixed + misc CS [#3005084]

All dependencies must be prefixed by project name. It was partly done but miss a lot.

There are some module names to capitalize, description missing nd dot and missing last empty line.

Hope this helps.

Comment	File	Size	Author
#5	with_patch_Opigno module.png	78.06 KB	Aanal.addweb
#3	without_patch_Opigno_module.png	76.66 KB	zalak.addweb
#3	hunk_error_Opigno_module.png	106.81 KB	zalak.addweb
#3	dependency_Opigno_module.jpg	441.61 KB	zalak.addweb
#2	Update_dependencies_format_in_info.yml_3005084-2.patch	4.35 KB	chipway

Comments

Comment #1

8 October 2018 at 13:32

chipway created an issue. See original summary.

Status	File	Size
new	Update_dependencies_format_in_info.yml_3005084-2.patch	4.35 KB

Comment #3

zalak.addweb commented 3 November 2018 at 17:51

Status:

Needs review

» Needs work

Status	File	Size
new	dependency_Opigno_module.jpg	441.61 KB
new	hunk_error_Opigno_module.png	106.81 KB
new	without_patch_Opigno_module.png	76.66 KB

@chipway, Thanks for the patch, but your patch is causing an hunk error while checking it in my local. Can you please do the needful?

Comment #4

chipway commented 5 November 2018 at 10:30

Status:

Needs work

» Needs review

Thanks for review, but It still applies cleanly (appliqué proprement) on my Dev :

/drupal8/modules/opigno_module (8.x-1.x=) $ git apply -v ../Update_dependencies_format_in_info.yml_3005084-2.patch
Vérification du patch ActivityTypes/opigno_file_upload/opigno_file_upload.info.yml...
Vérification du patch ActivityTypes/opigno_h5p/opigno_h5p.info.yml...
Vérification du patch ActivityTypes/opigno_long_answer/opigno_long_answer.info.yml...
Vérification du patch ActivityTypes/opigno_scorm_activity/opigno_scorm_activity.info.yml...
Vérification du patch ActivityTypes/opigno_tincan_activity/opigno_tincan_activity.info.yml...
Vérification du patch ActivityTypes/opigno_video/opigno_video.info.yml...
Vérification du patch modules/opigno_module_group/opigno_module_group.info.yml...
Vérification du patch opigno_module.info.yml...
Patch ActivityTypes/opigno_file_upload/opigno_file_upload.info.yml appliqué proprement.
Patch ActivityTypes/opigno_h5p/opigno_h5p.info.yml appliqué proprement.
Patch ActivityTypes/opigno_long_answer/opigno_long_answer.info.yml appliqué proprement.
Patch ActivityTypes/opigno_scorm_activity/opigno_scorm_activity.info.yml appliqué proprement.
Patch ActivityTypes/opigno_tincan_activity/opigno_tincan_activity.info.yml appliqué proprement.
Patch ActivityTypes/opigno_video/opigno_video.info.yml appliqué proprement.
Patch modules/opigno_module_group/opigno_module_group.info.yml appliqué proprement.
Patch opigno_module.info.yml appliqué proprement.

Please review.

Comment #5

Aanal.addweb commented 30 November 2018 at 12:26

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	with_patch_Opigno module.png	78.06 KB

@chipway, Thanks for providing the patch, Your patch is working fine for me as per the mentioned change above & also as per the standards. I checked it in my local over extend page. PFA.