Circular reference detected for service "router.route_provider"

Get the same (no lightning distribution)
Drush 8.1.16 or Drupal Console 1.8.0 report same error when running Cache rebuild
everything else seems to be working fine

@kevin.pfeifer Thanks for validating that.

This isn't an error we run into in our automated testing, or that I can easily reproduce.

Granted, I'm using drush 8.1.12...

So do we think this is an issue that on ly occurs when using drush 9?

Tested with drush 9.5.2 and no error.

> domain: drush --version
Drush Launcher Version: 0.6.0
Drush Commandline Tool 9.5.2
> domain: drush cr
 [success] Cache rebuild complete.
> domain: 

Looking for reliable steps to reproduce this issue.

Hi Ken,

thanks a lot for verifying this issue. We will try to give you reliable steps to reproduce this issue as soon as we can. The problem occurred after updating to Drupal 8.6.1 but this was not the issue. We'll get back to you when we have more information. Thanks.

Best,
Chris

Closed #3011661: Circular reference detected for service as a duplicate issue.

I don’t think the patch in #11 should actually be needed once you disable the “Account administrator pages” language negotiation?

Anyways, to maybe provide a bit more information: The attached patch might be a “fix” that could actually be committed to this module. The current code is of course not actually a bug per se, but as we see, under some conditions (in addition to the “Account administrator pages” language negotiation, the key was also having a module with a hook_entity_type_alter() implementation that requires \Drupal::config() – the Contact module (in Core) in this case) it can lead to a very-hard-to-debug problem that kills the whole site. So, adding this patch to the module should probably be considered – the code gets just a tiny bit “uglier”, perhaps, but functionality will be completely unchanged in normal cases, and it helps prevent this strange problem.

Thanks drunken monkey. Great fix, very much appreciated!

Yeah, this is one of those bad edge cases where not using Dependency Injection might be proper. It will at least save us from having to hunt down hard to replicate bugs. We had to use the same approach in DomainConfigOverrider.

I'm just back from vacation. I'll try to spin up a test branch for this by end of week.

Regenerated patch after #2976907: [Domain] Follow Drupal coding standards landed.

Tests at https://github.com/agentrickard/domain/pull/461

@agentrickard

I have this issue

Uncaught PHP Exception Symfony\\Component\\DependencyInjection\\Exception\\ServiceCircularReferenceException: "Circular reference detected for service "domain.negotiator", path: "options_request_listener -> router.route_provider -> path_processor_manager -> domain_source.path_processor -> domain.negotiator"." at /var/www/htdocs/xxxxx/core/lib/Drupal/Component/DependencyInjection/Container.php line 141,

Let me know whether this patch fix this issue

#12 works for me, possibly also #16 but #16 does not apply to 1.0.0-alpha14, because the Drupal code style additions have not had a release yet.

Drush Version: 8.1.10
Drupal Core Version: 8.6.2
Domain Access version: 1.0.0-alpha14

Also when I revert drupal/core back to 8.5.6 there seems to be no exception thrown.

@drunken monkey/ @agentrickard

I am getting this error regularly

Uncaught PHP Exception Symfony\\Compone
nt\\DependencyInjection\\Exception\\ServiceCircularReferenceException: "Circular reference detected for service "domain.negotiator", path: "options_request_listener -> router.route_provider -> path_processor_manager -> domain_source.path_processor -> domain.negotiator"." at /var/www/html/xxx/core/lib/Drupal/Component/DependencyInjection/Container.php line 141

Please let me know #12 or #16 will fix this error. Its very urgent.

The patch in #16 should work fine.

Committed.

https://github.com/agentrickard/domain/pull/461

  Circular reference detected for service "domain.route_provider", path: "twig -> twig.extension -> url_generator -> domain.route_provider -> path_processor_manager -> country_
path.  
  path_processor -> mymodule.main_service -> pathauto.generator -> pathauto.alias_uniquifier".

if comment 2 below then no error

  mymodule.main_service:
    class: Drupal\mymodule\MainService
    arguments: [
      '@entity_type.manager', 
      '@config.factory', 
      '@domain.negotiator', 
      '@language_manager', 
      #'@pathauto.generator',
      '@path_alias.manager',
      #'@pathauto.alias_uniquifier',
      '@token.entity_mapper',
      '@pathauto.alias_storage_helper',
      '@token',
      '@pathauto.alias_cleaner'
    ]