[D7] XML Sitemap Bulk Link Exclude

Hello @Logesh Waran,

I have checked your module in PAReview and there is no error. Great!!!

Your module is a much needed one. You have classified the XML site exclude by both ways

1. Exclude links by textarea
2. Exclude links by table

That's Awesome and developer friendly too. I like the "Exclude links by textarea" way.

I have found one error, In XML sitemap Bulk Link Exclude Table page is showing your config path (admin/config/search/list/xml_exclude_links) under the URL column by default. For your quick identification I have attached the screenshot.

Could you fix the issue?

Hello @Logesh waran

First of all great module, i have found a very small issue, i just install module and check "Xml Sitemap Bulk link exclude table" which is empty of course, so i got message which says "No users found", I think it should be "No links found".

Hello @Logesh waran

you have used following code to update xml sitemap link.

$check_val = isset($form_state['values']['table']) ? $form_state['values']['table'] : '';
  if ($check_val !== '') {
    foreach ($check_val as $key => $value) {
      if (!is_null($check_val[$key]) || $check_val[$key] !== '') {
        $fields = array('status' => 0, 'status_override' => 1);
        db_update('xmlsitemap')->fields($fields)->condition('loc', $value, '=')->execute();
      }
    }
    drupal_set_message(t('Selected xml links has been successfully removed from xml sitemap!. Please regenerate
    the sitemap to see the changes.'));
  }

$exclude_values = isset($form_state['values']['xml_sitemap_bulk_link_exclude_array']) ? $form_state['values']['xml_sitemap_bulk_link_exclude_array'] : '';

  if (!empty($exclude_values)) {
    foreach ($exclude_values as $key => $value) {
      if (isset($exclude_values[$key])) {
        $fields = array('status' => 0, 'status_override' => 1);
        db_update('xmlsitemap')->fields($fields)->condition('loc', $value, '=')->execute();
      }
    }
  }
  else {
    drupal_set_message(t("There are no links entered to exclude."));
  }

Where you are directly updating the values in tables, which will compliantly ignore "hook_xmlsitemap_link_update". you should use drupal_alter in your code, so other modules can still do there stuff with this module.

Hi @Logesh,

Your latest code is removed the config path(admin/config/search/list/xml_exclude_links) and changed typo error of "No users found" refer(#15).

Hi @sagar_cis,

#20 - Actually, The site admin can directly remove the sitemap URLs using the configuration. It is not necessary to add drupal_alter(HOOK).

And those pages are built by the Drupal form, so you can easily able to override the form_state values (XML-site URLs) using form_alter.

Actually, #20 is correct: When there is a hook that is invoked when data is changed, it should be invoked. It's exactly what Drupal does when an entity is changed: It doesn't simply alter the values in the database tables, but also invoke those hooks that tell the modules an entity has been changed.

Logesh,

I have checked your module and everything seems to be working fine. So I will change your module status to RTBC.

All the best.

Thanks,
Jaba

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.