Closed (fixed)
Project:
Tour Builder
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Oct 2018 at 10:20 UTC
Updated:
22 Oct 2018 at 13:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chipway commentedHere is the patch. Please review.
I also
removed some unnecessary quotes.
capitalized some module name per coding standards.
Comment #3
clemens.tolboomI checked the CS part and wonder why this single quote has to go. Do you have a guideline for that?
Comment #4
clemens.tolboomSo most use single quote (551 ) and some use double quote (59) ... rest (137 - 59 = 78) use no quotes
And please fix the summary links :-)
Comment #5
chipway commentedThanks Clemens for your review and interesting comments. You right. I mixed best practices and added a suggestion.
Here are the right links for summary :
All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml file
It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).
The suggestion part was to remove quotes as in examples given by
and recommadation in Ultimike comment (with Yaml references) https://www.drupal.org/project/drupal/issues/2994928#comment-12802226
Here is a patch on the best practice part (namespacing and capitalize).
Please review.
Comment #6
chipway commentedComment #7
clemens.tolboomYou can edit the summary yourself ;-) it's below the comment form element. Sometimes closed/collapsed
Comment #9
chipway commentedOh, yes. It was collapsed.
Thanks Clemens.
Comment #10
clemens.tolboom