All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

It is useful for Installation profiles to work well. So sooner is better.
Hope this helps.

Comments

chipway created an issue. See original summary.

chipway’s picture

Title: Update Dependencies to new Format in .info.yml » Update Dependencies to new Format in .info.yml + misc CS
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new399 bytes

Here is the patch. Please review.
I also
removed some unnecessary quotes.
capitalized some module name per coding standards.

clemens.tolboom’s picture

Status: Needs review » Postponed (maintainer needs more info)

I checked the CS part and wonder why this single quote has to go. Do you have a guideline for that?

cd core
find . -name "*.yml" -exec cat {} \; > ../../core-yaml.txt
...
# remove all blanks to get normilized string
cat core-yaml.txt | tr -d "[:blank:]"

# description using single quote
cat core-yaml.txt | tr -d "[:blank:]" | sort -u | grep description | grep ":'" | wc -l
     551

# description not using a single quote
cat core-yaml.txt | tr -d "[:blank:]" | sort -u | grep description | grep -v ":'" | wc -l
#     137

# Descriptions using double quote
cat core-yaml.txt | tr -d "[:blank:]" | sort -u | grep description | grep ':"' | wc -l
      59
clemens.tolboom’s picture

Issue summary: View changes

So most use single quote (551 ) and some use double quote (59) ... rest (137 - 59 = 78) use no quotes

And please fix the summary links :-)

chipway’s picture

Title: Update Dependencies to new Format in .info.yml + misc CS » Update Dependencies to new Format in .info.yml + capitalize name
Assigned: Unassigned » chipway
Status: Postponed (maintainer needs more info) » Needs work
StatusFileSize
new353 bytes

Thanks Clemens for your review and interesting comments. You right. I mixed best practices and added a suggestion.

Here are the right links for summary :
All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

The suggestion part was to remove quotes as in examples given by
and recommadation in Ultimike comment (with Yaml references) https://www.drupal.org/project/drupal/issues/2994928#comment-12802226

Here is a patch on the best practice part (namespacing and capitalize).

Please review.

chipway’s picture

Assigned: chipway » Unassigned
Status: Needs work » Needs review
clemens.tolboom’s picture

You can edit the summary yourself ;-) it's below the comment form element. Sometimes closed/collapsed

chipway’s picture

Issue summary: View changes

Oh, yes. It was collapsed.
Thanks Clemens.

clemens.tolboom’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.