Problem/Motivation
While evaluating the Umami profile we found a grammar issue in the Veggie Pasta Bake recipe.
drupal/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/veggie-pasta-bake-umami.html
Grill for 10 minutes or the cheese as melted and started to brown.
should read = >
Grill for 10 minutes or until the cheese has melted and started to brown.
Steps to Reproduce:
1. Navigate to https://simplytest.me/project/drupal/8.7.x?patch[]=https://www.drupal.or...
2. Open the Advanced section and select Bypass Installation, selecting Launch Sandbox and proceeding through the Drupal installation selecting Umami Demo on the Choose Profile step
3. When prompted, use the section before .ply.st in the address of the site for username, password and database name , eg for dmc3b.ply.st, use dmc3b
4. Check the following page for the change in this patch:
/recipes/super-easy-vegetarian-pasta-bake
Proposed resolution
Fix it by uploading a patch for that file.
Remaining tasks
Upload patch
Review patch
Commit patch
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Patch forthcoming, thanks!!
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3004659.png | 79.54 KB | jqtnguyen |
| #2 | drupal-grammar-veggiebake-recipe-umami-demo-3004659-2.patch | 1.24 KB | volkswagenchick |
Comments
Comment #2
volkswagenchickI have uploaded a patch that fixes the grammar issue in the Veggie Pasta Bake content file.
drupal/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/veggie-pasta-bake-umami.html
Welcome for feedback if others want to weigh in!
Thanks for all the work on this demo project.
Comment #3
nerdsteinI have reviewed this patch and, yes, it addresses the grammar error with the sentence. I recommend that this should be committed for polish.
Comment #4
jqtnguyen commentedI tested this patch, it applied without fail, and the changes look good. I've attached a screenshot of what it looks like on my end.
Comment #6
lauriiiCommitted df2865f and pushed to 8.7.x. Also cherry-picked to 8.6.x. Thanks!