Fix style submitBehaviorForm when the style plugin is enabled and only one style enabled

Seems fine to me and works.

Just tried this out, cannot reproduce the problem. Was there any extra patch added here?

I cannot reproduce since in the ParagraphsWidget file there is a check to see if the behavior_plugins element was added, having only one style set as default wouldn't go through that check and thus we wouldn't get this error.

[EDIT] Just tested again and this happens when having more than one Style enabled. Updating the issue summary.

There we go, this should trigger the bug.

Fixing issue title.

1. +++ b/src/Plugin/paragraphs/Behavior/ParagraphsStylePlugin.php
   @@ -121,7 +121,8 @@ class ParagraphsStylePlugin extends ParagraphsBehaviorBase implements ContainerF
   -    $paragraph->setBehaviorSettings($this->pluginId, $form_state->getValues()['style_wrapper']);
   +    $settings = isset($form_state->getValues()['style_wrapper']) ? $form_state->getValues()['style_wrapper'] : [];
   +    $paragraph->setBehaviorSettings($this->pluginId, $settings);
      }
    
   

   you can probably simplify this to $form_state->getValue('style_wrapper', [])

2. +++ b/tests/src/FunctionalJavascript/ParagraphsCollectionStylePluginTest.php
   @@ -0,0 +1,84 @@
   + * Test paragraphs collection style behavior.
   + *
   + * @group paragraphs_collection
   + */
   +class ParagraphsCollectionStylePluginTest extends JavascriptTestBase {
   +
   

   Do we really need a JS test to trigger this? Might be easier and faster with a plain browser test?

   All the fields are there to in a browser test.

   If it requires JS then we should merge it with the ParagraphsCollectionStyleTest that I added in the other issue.

Ha! Took me longer than expected. Somehow when trying to create the paragraph through the UI, the groups config of the Style plugin was null. Not sure what went wrong there, switched to setting config programatically. :)

The error I got was

1) Drupal\Tests\paragraphs_collection\Functional\ParagraphsCollectionStylePluginTest::testStylePlugin
Exception: Warning: array_keys() expects parameter 1 to be array, null given
Drupal\paragraphs_collection\Plugin\paragraphs\Behavior\ParagraphsStylePlugin->buildConfigurationForm()() (Line: 159)

[EDIT] If happens again I will create an issue.

+++ b/src/Plugin/paragraphs/Behavior/ParagraphsStylePlugin.php
@@ -121,7 +121,9 @@ class ParagraphsStylePlugin extends ParagraphsBehaviorBase implements ContainerF
   public function submitBehaviorForm(ParagraphInterface $paragraph, array &$form, FormStateInterface $form_state) {
-    $paragraph->setBehaviorSettings($this->pluginId, $form_state->getValues()['style_wrapper']);
...
+    $settings = isset($settings) ? $settings : [];

still too complicated?

Just do $paragraph->setBehaviorSettings($this->pluginId, $form_state->getValue('style_wrapper', [])); the second argument is the default and that already ensures that it is always an array.

Ha! Didn't notice that, thanks! Updating, no interdiff, too big. :)

Oops, my bad.

Committed.