The module should be converted from using calls to Drupal class and use dependency injection.

CommentFileSizeAuthor
#2 3003684-tour_ui-dependency_injection-2.patch6.15 KBsean_e_dietrich

Comments

sean_e_dietrich created an issue. See original summary.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
StatusFileSize
new 3003684-tour_ui-dependency_injection-2.patch6.15 KB

Patch submitted to fix dependency injection conversion.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Active » Fixed

Awesome! Committed.

[edit]Never mind; test result is clear on https://www.drupal.org/node/1933602/qa
@sean_e_dietrich any idea what is wrong with testing?[/edit]

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Parent issue: » #2995572: Clean up the code: CS

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.