Closed (fixed)
Project:
Image Hover Effects
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Oct 2018 at 07:27 UTC
Updated:
1 Dec 2018 at 06:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chipway commentedHere is the patch. Please review.
Comment #3
alonaoneill commentedCode looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!
Comment #4
jurriaanroelofs commentedThanks, can you send me a link to the release note or docs for this change? I haven't heard of it before.
Comment #6
jurriaanroelofs commentedthanks!
Comment #7
volkswagenchickAccording to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...