There's a Views issue in PHP 7.1 that is causing PHP warnings, see #2885660: Warning: A non-numeric value encountered in views_plugin_pager_full->query(). Add that issue's patch to panopoly_core.

CommentFileSizeAuthor
#4 interdiff-2-4.txt652 bytescboyden
#4 panopoly_core-views-php7-3002885-4.patch686 bytescboyden
#2 panopoly_core-views-php-71-warning-3002885-2.patch570 bytescboyden

Comments

cboyden created an issue. See original summary.

cboyden’s picture

cboyden commented
Assigned: cboyden » Unassigned
Status: Active » Needs review
StatusFileSize
new panopoly_core-views-php-71-warning-3002885-2.patch570 bytes

Here's a patch to add the Views patch.

cboyden’s picture

cboyden commented
Issue tags: +PHP 7.0 (duplicate)
cboyden’s picture

cboyden commented
StatusFileSize
new panopoly_core-views-php7-3002885-4.patch686 bytes
new interdiff-2-4.txt652 bytes

There's another PHP 7.2 Views patch at #2977851: PHP 7.2: count() on non-Countable in views_many_to_one_helper.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Here's a test build on Travis:

https://travis-ci.org/panopoly/panopoly/builds/445346790

  • dsnopek committed 532eb87 on 7.x-1.x 
    Update Panopoly Core for Issue #3002885 by cboyden: Patch Views for PHP...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tests pass - we actually have a bunch of Views testing in our test suite! Patches look good. Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.