[D7] CleverReach® - Newsletter Marketing

We just review a single project, and a single branch.
Please choose the project/branch you want reviewed, and edit the OP to reflect your choice.

When editing the OP, remember to add [D7] or [D8] at the beginning of the title, basing on which branch you want to be reviewed.

See the errors reported by PAReview.

function clever_reach_is_event_fire_allowed() {
  $queueService = ServiceRegister::getService(Queue::CLASS_NAME);

  if (!$queueService->findLatestByType('InitialSyncTask')) {
    return FALSE;
  }

  return module_exists('clever_reach');
}

If the module is not enabled, clever_reach_is_event_fire_allowed() cannot be called; if the module is enabled, module_exists('clever_reach') will return TRUE. This means the last line can simply be replaced by the following one.

  return TRUE;

Better, the full function can be changed as follows.

function clever_reach_is_event_fire_allowed() {
  $queueService = ServiceRegister::getService(Queue::CLASS_NAME);

  return (bool) $queueService->findLatestByType('InitialSyncTask');
}

  public function getAttributeByName($attributeName) {
    $attribute = new ShopAttribute();
    $mappedAttribute = $this->getMappedAttribute($attributeName);

    if ($mappedAttribute !== NULL) {
      $attribute->setDescription(t($mappedAttribute));
    }

    return $attribute;
  }

The first argument of t() needs to be a literal string, not a variable.

  /**
   * Create and send request asynchronously.
   *
   * @param string $method
   *   Request method.
   * @param string $url
   *   Request url.
   * @param mixed $headers
   *   Request headers.
   * @param string $body
   *   In JSON format.
   *
   * @return \CleverReach\Infrastructure\Utility\HttpResponse
   *   Http response object that contains response information such
   *   as headers, body and status.
   */
  public function sendHttpRequestAsync($method, $url, $headers = array(), $body = '') {
    $this->setCurlSessionAndCommonRequestParts($method, $url, $headers, $body);
    $this->setCurlSessionOptionsForAsynchronousRequest();
    return curl_exec($this->curlSession);
  }

  /**
   * Sets curl session parts.
   *
   * @param string $method
   *   Request method.
   * @param string $url
   *   Request url.
   * @param array $headers
   *   Request headers.
   * @param string $body
   *   In JSON format.
   */
  private function setCurlSessionAndCommonRequestParts($method, $url, array $headers, $body) {
    $this->initializeCurlSession();
    $this->setCurlSessionOptionsBasedOnMethod($method);
    $this->setCurlSessionUrlHeadersAndBody($method, $url, $headers, $body);
    $this->setCommonOptionsForCurlSession();
  }

  /**
   * Initializes curl session.
   */
  private function initializeCurlSession() {
    $this->curlSession = curl_init();
  }

Is there any reason not to use drupal_http_request()?

  private function isEmail($input) {
    return strpos($input, '@') !== FALSE;
  }

filter_var() can validate a string containing an email address.

It's not a requirement: I just wanted to see if you were aware that Drupal has drupal_http_request().

I will approve the application later.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.