All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dephttps://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-... in info.yml filehttps://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-about-your-module-with-an-infoyml-file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

Hope this helps.

CommentFileSizeAuthor
#2 Update_dependencies_format_in_info.yml_3001783-2.patch358 byteschipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Title: All dependencies must be prefixed » All dependencies must be prefixed + capitalize name
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3001783-2.patch358 bytes

Here is the patch. Please review.

I also also capitalized module name per coding standards.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
alonaoneill’s picture

alonaoneill commented
Status: Needs review » Needs work

Code looks good. The dependency namespacing aligns with Drupal documentation standards, but patch didn't apply.
Marking as Needs work
Thank you for working on module!

chipway’s picture

chipway commented
Status: Needs work » Needs review

Thanks for review. Did you apply on 8.x-2.x-dev version ?

  • sch4lly committed 7e57e00 on 8.x-2.x authored by chipway 
    Issue #3001783 by chipway: All dependencies must be prefixed +...
sch4lly’s picture

sch4lly commented
Status: Needs review » Fixed

Committed and pushed. Thanks! I will not release a new version for this minor fix though, it will have to wait for the next bugfix release.

sch4lly’s picture

sch4lly commented
Status: Fixed » Closed (fixed)