Problem/Motivation
While evaluating the Umami profile we discovered that the word "mozzarella" is spelled incorrectly In the recipes.csv file for the "Gluten free pizza picture. The word "successful" is spelled incorrectly in the lets-hear-it-for-carrots.html file. And the word "asian" should be capitalized in the the-umami-guide-to-our-favourite-mushrooms.html file.
recipes.csv
mozzeralla and Parma ham = > mozzarella and Parma ham
lets-hear-it-for-carrots.html file
succesfull = > successful
the-umami-guide-to-our-favourite-mushrooms.html
omelette or an asian soup => omelette or an Asian soup
Proposed resolution
Fix it by uploading a patch for that file.
Remaining tasks
Upload patch
Review patch
Commit patch
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#18 | drupal-misspelling-umami-demo-3001782-18.patch | 9.04 KB | volkswagenchick |
#8 | drupal-misspelling-umami-demo-3001782-8.patch | 9.04 KB | volkswagenchick |
Comments
Comment #2
volkswagenchickI uploaded a patch that corrects the misspelling in the recipe. Thanks. The work you folks are doing on this demo is fantastic!
Comment #3
volkswagenchickComment #4
Kristen PolPlease add instructions on how to test this. Thanks.
Comment #5
Kristen PolI looked at the patch itself and it seems ok. The only change I saw was the spelling fix. I'd like to verify through the UI that this shows up correctly though. Thanks.
Comment #6
volkswagenchickI found additional misspelling/capitalization issues in the default_content folder. I am wondering if they should be included in the same patch?
lets-hear-it-for-carrots.html file
succesfull = > successful
the-umami-guide-to-our-favourite-mushrooms.html
omelette or an asian soup => omelette or an Asian soup
Comment #7
Kristen PolYes, it would be good to fix these at same time. Thanks.
Comment #8
volkswagenchickI uploaded a new patch with the additional misspelling/capitalization issues in comment 6. Thanks.
Comment #9
volkswagenchickComment #10
Eli-T@Kristen Pol the content is created at install time, so the easiest way to test is by
(I'm sure you know all/most the above but being thorough in case someone else picks it up)
Comment #11
Eli-TWhilst Umami changes almost always get cherry-picked back to 8.6.x, we still raise them against the next minor version as for any other core change and let the committers decide whether to cherry-pick back the the current version.
Comment #12
parijke CreditAttribution: parijke as a volunteer commented@Eli-T I did not know that! Excellent trick/tip.
Going to review the patch now
Comment #13
parijke CreditAttribution: parijke as a volunteer commentedChecked it and the words are nicely spelled correctly on install
Comment #14
parijke CreditAttribution: parijke as a volunteer commentedComment #15
longwaveThere is an inconsistency here, both "U.K." and "UK" are used. Should we fix this here? Not sure which style we prefer.
Comment #16
parijke CreditAttribution: parijke as a volunteer commentedSharp @longwave
Comment #17
Eli-THaving a look through the current Umami content, I can only find one other initialisation: BBQ - /articles/skip-the-spirits-with-delicious-mocktails. So no periods there.
https://www.gov.uk/search?q=UK has 101,621 results but https://www.gov.uk/search?q=U.K. turns up only 136. So on the UK government's own website, UK is far more used.
So I suggest standardising on UK.
Comment #18
volkswagenchickI uploaded a patch that makes the changes in comment 15, using "UK".
I tried to make an interdiff - but failed, sorry.
Comment #19
Eli-TTested the patch in #18 and verified the change suggested in #17 made successfully.
Manually diffed the previously reviewed patch in #8 and #18 to verify nothing else had changed.
Therefore moving to RTBC again. Thanks!
Comment #20
longwaveFixed another spelling error ;)
Comment #21
alexpottCommitted and pushed eebd8656d4 to 8.7.x and 83ec398547 to 8.6.x. Thanks!