Problem/Motivation

While evaluating the Umami profile we discovered that the word "mozzarella" is spelled incorrectly In the recipes.csv file for the "Gluten free pizza picture. The word "successful" is spelled incorrectly in the lets-hear-it-for-carrots.html file. And the word "asian" should be capitalized in the the-umami-guide-to-our-favourite-mushrooms.html file.

recipes.csv
mozzeralla and Parma ham = > mozzarella and Parma ham

lets-hear-it-for-carrots.html file
succesfull = > successful

the-umami-guide-to-our-favourite-mushrooms.html
omelette or an asian soup => omelette or an Asian soup

Proposed resolution

Fix it by uploading a patch for that file.

Remaining tasks

Upload patch
Review patch
Commit patch

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

Assigned: volkswagenchick » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
4.5 KB

I uploaded a patch that corrects the misspelling in the recipe. Thanks. The work you folks are doing on this demo is fantastic!

volkswagenchick’s picture

Kristen Pol’s picture

Please add instructions on how to test this. Thanks.

Kristen Pol’s picture

I looked at the patch itself and it seems ok. The only change I saw was the spelling fix. I'd like to verify through the UI that this shows up correctly though. Thanks.

volkswagenchick’s picture

I found additional misspelling/capitalization issues in the default_content folder. I am wondering if they should be included in the same patch?

lets-hear-it-for-carrots.html file
succesfull = > successful

the-umami-guide-to-our-favourite-mushrooms.html
omelette or an asian soup => omelette or an Asian soup

Kristen Pol’s picture

Yes, it would be good to fix these at same time. Thanks.

volkswagenchick’s picture

I uploaded a new patch with the additional misspelling/capitalization issues in comment 6. Thanks.

volkswagenchick’s picture

Title: Misspelling in Unami Gluten-free pizza recipe » Misspellings and capitalization error in Unami content files
Eli-T’s picture

@Kristen Pol the content is created at install time, so the easiest way to test is by

  1. going to https://simplytest.me/project/drupal/8.7.x?patch[]=https://www.drupal.or...
  2. checking the Bypass installation checkbox in the Advanced section, clicking Launch Sandbox and proceeding through the Drupal installation selecting Umami Demo on the Choose Profile step
  3. when prompted, use the section before .ply.st in the address of the site for username, password and database name , eg for dmc3b.ply.st, use dmc3b
  4. check the following pages for the changes in this patch:
  5. /articles/lets-hear-it-for-carrots
  6. /articles/the-umami-guide-to-our-favourite-mushrooms
  7. /recipes/gluten-free-pizza

(I'm sure you know all/most the above but being thorough in case someone else picks it up)

Eli-T’s picture

Version: 8.6.x-dev » 8.7.x-dev

Whilst Umami changes almost always get cherry-picked back to 8.6.x, we still raise them against the next minor version as for any other core change and let the committers decide whether to cherry-pick back the the current version.

parijke’s picture

@Eli-T I did not know that! Excellent trick/tip.

Going to review the patch now

parijke’s picture

Checked it and the words are nicely spelled correctly on install

parijke’s picture

Status: Needs review » Reviewed & tested by the community
longwave’s picture

Status: Reviewed & tested by the community » Needs review
+++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/article_body/lets-hear-it-for-carrots.html
@@ -8,4 +8,4 @@ <h2>Nutrition</h2>
+<p>Of course it's a myth. During World War II the U.K. Ministry of Food promoted carrots as a super healthy veggie that would improve your ability to see during the blackouts and as an explanation for the successful night missions of UK fighter pilots. In reality, the only truth in the connection between carrots and improved eye sight is that vitamin A does indeed help to maintain vision.</p>

There is an inconsistency here, both "U.K." and "UK" are used. Should we fix this here? Not sure which style we prefer.

parijke’s picture

Sharp @longwave

Eli-T’s picture

Status: Needs review » Needs work

Having a look through the current Umami content, I can only find one other initialisation: BBQ - /articles/skip-the-spirits-with-delicious-mocktails. So no periods there.

https://www.gov.uk/search?q=UK has 101,621 results but https://www.gov.uk/search?q=U.K. turns up only 136. So on the UK government's own website, UK is far more used.

So I suggest standardising on UK.

volkswagenchick’s picture

Status: Needs work » Needs review
FileSize
9.04 KB

I uploaded a patch that makes the changes in comment 15, using "UK".

I tried to make an interdiff - but failed, sorry.

Eli-T’s picture

Status: Needs review » Reviewed & tested by the community

Tested the patch in #18 and verified the change suggested in #17 made successfully.

Manually diffed the previously reviewed patch in #8 and #18 to verify nothing else had changed.

Therefore moving to RTBC again. Thanks!

longwave’s picture

Title: Misspellings and capitalization error in Unami content files » Misspellings and capitalization error in Umami content files

Fixed another spelling error ;)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed eebd8656d4 to 8.7.x and 83ec398547 to 8.6.x. Thanks!

  • alexpott committed eebd865 on 8.7.x
    Issue #3001782 by volkswagenchick, Eli-T, parijke, Kristen Pol, longwave...

  • alexpott committed 83ec398 on 8.6.x
    Issue #3001782 by volkswagenchick, Eli-T, parijke, Kristen Pol, longwave...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.