According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
While reviewing this module, we noticed that the dependencies are not properly formatted.
Patch to follow...
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | webform_simplenews_handler-info-3001612-2.patch | 433 bytes | alonaoneill |
| #3 | webform_simplenews_handler-update-format-dependencies-3001612-3.patch | 0 bytes | jqtnguyen |
Comments
Comment #2
jqtnguyen commentedComment #3
jqtnguyen commentedUploading patch for issue.
Comment #4
volkswagenchickPatch appears to be empty.
Comment #5
alonaoneill commentedI uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!
Comment #6
volkswagenchickLooks good. Dependencies are all namespaced appropriately
Patch applied via simplytest.me
Marking RTBC
Comment #8
netsliverFixed in dev version