Coding standard

1. +++ b/src/Annotation/EntityUsageTrack.php
   @@ -43,6 +43,6 @@ class EntityUsageTrack extends Plugin {
   -  public $field_types = [];
   +  public $fieldtypes = [];
   

   This change may break the functionality as you are renaming the property. You should change the name of property at all places wherever it is being accessed. Also the correct name should be $fieldTypes.

2. +++ b/tests/modules/entity_usage_test/entity_usage_test.info.yml
   @@ -3,7 +3,7 @@ type: module
   +version: ¶
   

   Remove trailing whitespace.

3. +++ b/tests/src/Kernel/EntityUsageLegacyEntityReferenceKernelTest.php
   @@ -191,11 +190,10 @@ class EntityUsageLegacyEntityReferenceKernelTest extends EntityKernelTestBase {
   -//    $source_entity->{$field_name}->entity = $this->testEntities[1];
   -//    $source_entity->save();
   -//    $usage = $entity_usage->listSources($this->referencedEntity);
   -//    $this->assertSame([], $usage, 'Non-referenced usage is correctly empty.');
   -
   +    // $source_entity->{$field_name}->entity = $this->testEntities[1];
   +    // $source_entity->save();
   +    // $usage = $entity_usage->listSources($this->referencedEntity);
   +    // $this->assertSame([], $usage,'Non-referenced usage is correctly empty.');
   
   @@ -215,29 +213,27 @@ class EntityUsageLegacyEntityReferenceKernelTest extends EntityKernelTestBase {
   -//    $source_entity->delete();
   -//    $usage = $entity_usage->listSources($this->referencedEntity);
   -//    $this->assertSame([], $usage, 'Non-referenced usage is correctly empty.');
   -
   +    // $source_entity->delete();
   +    // $usage = $entity_usage->listSources($this->referencedEntity);
   +    // $this->assertSame([], $usage,'Non-referenced usage is correctly empty.');
        // Create a reference again, check the value is back to 1.
   -//    $source_entity = $this->testEntities[1];
   -//    $source_entity->{$field_name}->entity = $this->referencedEntity;
   -//    $source_entity->save();
   -//    $usage = $entity_usage->listSources($this->referencedEntity);
   -//    $this->assertEquals([
   -//      $source_entity->getEntityTypeId() => [
   -//        $source_entity->id() => [
   -//          0 => [
   -//            'source_langcode' => $source_entity->language()->getId(),
   -//            'source_vid' => $source_entity->getRevisionId() ?: 0,
   -//            'method' => 'entity_reference',
   -//            'field_name' => $field_name,
   -//            'count' => 1,
   -//          ],
   -//        ],
   -//      ],
   -//    ], $usage, 'The usage count is correct.');
   -
   +    // $source_entity = $this->testEntities[1];
   +    // $source_entity->{$field_name}->entity = $this->referencedEntity;
   +    // $source_entity->save();
   +    // $usage = $entity_usage->listSources($this->referencedEntity);
   +    // $this->assertEquals([
   +    // $source_entity->getEntityTypeId() => [
   +    // $source_entity->id() => [
   +    // 0 => [
   +    // 'source_langcode' => $source_entity->language()->getId(),
   +    // 'source_vid' => $source_entity->getRevisionId() ?: 0,
   +    // 'method' => 'entity_reference',
   +    // 'field_name' => $field_name,
   +    // 'count' => 1,
   +    // ],
   +    // ],
   +    // ],
   +    // ], $usage, 'The usage count is correct.');
   

   Commented code should be removed all together.

Working on it.

Uploading fixes for #5.Hope it helps.

+++ b/src/EntityUsageTrackBase.php
@@ -217,13 +217,13 @@ abstract class EntityUsageTrackBase extends PluginBase implements EntityUsageTra
-  public function getReferencingFields(EntityInterface $source_entity, array $field_types) {
+  public function getReferencingFields(EntityInterface $source_entity, array $fieldTypes) {

You do not need to change method parameter here because this is creating inconsistency. You can keep it $field_types.

Also, you will need to fix property name in test cases as well because the tests are still expecting field_types property in the class.

I wonder if this change may break the upgrade path of this module if there is any.

Thanks Mahesh for reviewing. As i checked there isn't any hardcoded property name used under the test cases. Also find below patch which is correction from #8. Thanks.

+++ b/src/Plugin/EntityUsage/Track/DynamicEntityReference.php
@@ -21,7 +21,7 @@ class DynamicEntityReference extends EntityUsageTrackBase {
-    /** @var \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem$item */
+    /* @var \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem$item */

This should has /** in starting and */ in end. There should be single space between the variable type and the variable $item. Something like:
/** @var \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem $item */

See #2305593: [policy] Set a standard for @var inline variable type declarations

Rest looks good.

working on it.

Here is the update patch. This solves from #15

@dhirendra.mishra Please provide the interdiff as well whenever you are providing a patch which modifies something from the previous patch. This will help the reviewer to spend less time reviewing.

+++ b/src/Plugin/EntityUsage/Track/DynamicEntityReference.php
@@ -21,7 +21,7 @@ class DynamicEntityReference extends EntityUsageTrackBase {
-    /** @var \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem$item */
+    /* @var \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem $item */

I can see you have added a space between variable type and variable name $item. As per the standard inline @var comment should start with double asterisk /** not with single asterisk /*.

Please find below updated patch.

LGTM. @deepanker_bhalla good work. Moving this to RTBC.

This has apparently been fixed elsewhere. Thanks in any case for the help!