Problem/Motivation

7.x backport for #2142107: Complex cloned query dependent on __toString() call

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 3000191-9.patch2.87 KBpoker10
#9 3000191-9_test-only.patch1.96 KBpoker10
#2 2142107-16--fix_select_query_clone.patch923 bytesdrunken monkey

Comments

catch created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2142107-16--fix_select_query_clone.patch923 bytes

Re-posting the patch from #2142107-16: Complex cloned query dependent on __toString() call.

Status: Needs review » Needs work

The last submitted patch, 2: 2142107-16--fix_select_query_clone.patch, failed testing. View results

giorgio79’s picture

giorgio79 commented
Status: Needs work » Reviewed & tested by the community

This patch was tested and reviewed already for a long time for D7 :)

Anonymous’s picture

Anonymous (not verified) commented

Patch workes for me on a live site

Anonymous’s picture

Anonymous (not verified) commented

Patch against Drupal 7.61 is ok.

amir simantov’s picture

amir simantov commented

MUST GO INTO CORE!

Works for me, works for everybody. Please submit into next release, thanks!

knyshuk.vova’s picture

knyshuk.vova commented

+1 to RTBC

poker10’s picture

poker10 commented
StatusFileSize
new 3000191-9_test-only.patch1.96 KB
new 3000191-9.patch2.87 KB

Patch #2 looks good. I am not sure why the test from D8 patch was not backported in the patch, it should possibly landed in D7 sooner. Adding a missing test and reuploading the patch with a test only version to verify. Patch itself is unchanged. The same code is still in D9.

The last submitted patch, 9: 3000191-9_test-only.patch, failed testing. View results

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 3000191-9.patch, failed testing. View results

poker10’s picture

poker10 commented
Status: Needs work » Reviewed & tested by the community

This was some random test failure, setting back to RTBC.

mcdruid’s picture

mcdruid commented
Issue tags: +RTBM

Looks great - thanks for backporting the tests too!

  • poker10 committed ee2a2c7 on 7.x 
    Issue #3000191 by poker10, drunken monkey: Complex cloned query...

poker10 credited Damien Tournoud.

poker10 credited emanaton.

poker10 credited gilsbert.

poker10 credited St_B.

poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -RTBM

Thanks everyone who contributed!

Added coresponding credits from the parent issue.

emanaton’s picture

emanaton commented

Holy zombie post, batman! =oD

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.