Closed (fixed)
Project:
Lightning API
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2018 at 07:33 UTC
Updated:
2 Mar 2019 at 15:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chipway commentedHere is the patch. Please review.
Comment #3
alonaoneill commentedCode looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!
Comment #4
phenaproximaThanks for the patch! Needs to be rerolled against 8.x-3.x, though. :(
Comment #5
neslee canil pintoUpdated Dependencies for composer in info.yml file
Comment #6
phenaproximaThis doesn't seem to apply either;
git applygives me "corrupt patch at line 22" :(Comment #7
neslee canil pintoUpdated Dependencies for composer in info.yml file
Comment #8
phenaproximaThis applies cleanly, thanks! Will merge when it passes CI.
Comment #10
phenaproximaCommitted and pushed to 8.x-3.x. Thanks!