Some minor issues with target language filter needs to be fixed:

  • Make sure the Target language filter is always mandatory
  • Make sure there are not an alternative named "Any" in the target language list
  • Remove hard-coded weight of Target language filter

These issues works fine in the demo view on the module, but not when adding new target language filters for new views.

UX improvements:

  • Enable by default the filter as exposed filter (as recommended)
  • Enable by default alternative "Remove rows where source language is equal to target language."
CommentFileSizeAuthor
#4 translation_views-fix_target_language_filter-2999861-3-D8.patch3.02 KBsergei_semipiadniy
#3 translation_views-fix_target_language_filter-2999861-2-D8.patch3.02 KBsergei_semipiadniy
fix-target-language-filter-1.patch2.76 KBmatsbla

Comments

matsbla created an issue. See original summary.

matsbla’s picture

matsbla commented
Status: Active » Needs work
sergei_semipiadniy’s picture

sergei_semipiadniy commented
Status: Needs work » Needs review
StatusFileSize
new translation_views-fix_target_language_filter-2999861-2-D8.patch3.02 KB

Hi,

@matsbla, This one should work.

Regards!

sergei_semipiadniy’s picture

sergei_semipiadniy commented
StatusFileSize
new translation_views-fix_target_language_filter-2999861-3-D8.patch3.02 KB

Remove #weight key to allow widget ordering in a proper way.

Regards!

matsbla’s picture

matsbla commented
matsbla’s picture

matsbla commented
Issue summary: View changes

matsbla’s picture

matsbla commented
Status: Needs review » Fixed

Thanks for the help!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.