This is a very simple module which allows you to send your clients to make an off-site payment directly on the DIBS payment system.
It is different from https://www.drupal.org/project/dibs because the DIBS Payment Gateway API module is an API and is not integrated with Commerce 2.x.

Commerce DIBS integration is an out of the box module.

Project link

https://www.drupal.org/project/commerce_dibs

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/commerce_dibs.git

Comments

casaran created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

PAReview doesn't report any error. It just says the module doesn't implement tests. I will make a manual review of the code later.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community 
    $dibs_merchant_id = $payment_gateway_plugin->getConfiguration()['merchant'];
    $language = \Drupal::languageManager()->getCurrentLanguage()->getId();

Since the PaymentOffsiteForm class implements the ContainerInjectionInterface interface, it should not use \Drupal::languageManager() to get the language manager. It should do exactly as it did to get the module handler.

Apart that, I didn't find any security issue. I will approve this application this evening.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

casaran’s picture

casaran commented

Thank you for your review and approval!

I will also correct the issue you reported as soon as possible.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.