The Docblock for this function lists $value as mixed, but the typehint says array. This parameter is passed to array_filter, which expects an array, and is always called with an array, so the php typehint is correct. Update the docblock to match.

CommentFileSizeAuthor
#2 2999150-2.drupal.MigrationLookupskipOnEmpty-docblock-and-typehint-mismatch.patch672 bytesmikelutz

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2999150-2.drupal.MigrationLookupskipOnEmpty-docblock-and-typehint-mismatch.patch672 bytes
quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

I read the patch and the code and yes this change is correct. The method is only called once and $value is made an array before the call, so yes this is fine.

Thanks mikelutz!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 90f91f3e91 to 8.7.x and 51f35637c1 to 8.6.x. Thanks!

  • alexpott committed 90f91f3 on 8.7.x 
    Issue #2999150 by mikelutz: MigrationLookup::skipOnEmpty docblock and...

  • alexpott committed 51f3563 on 8.6.x 
    Issue #2999150 by mikelutz: MigrationLookup::skipOnEmpty docblock and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.