First of all thank you for this useful module, meanwhile when I try use this module for s3 storage it fails due using the FileSystem::realpath, as per documentation "The use of this method is discouraged, because it does not work for remote URIs ..." , also it will be very handy to support translation, going to attach a patch to add those couple of features

CommentFileSizeAuthor
#2 path_file-support-external-file-scheme-and-allow-entity-to-be-translatable-2998539-2.patch3.15 KBmgalalm

Issue fork path_file-2998539

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mgalalm created an issue. See original summary.

mgalalm’s picture

mgalalm commented
Title: Support external file schema .e.g S3 and make the entity itself translatable » Support external file scheme .e.g S3 and make the entity itself translatable
StatusFileSize
new path_file-support-external-file-scheme-and-allow-entity-to-be-translatable-2998539-2.patch3.15 KB

OK, here is my patch for review, please feel free to rip this apart

bgronek’s picture

bgronek commented

Has anyone tested or considered adding this to the code base?

pachabhaiya made their first commit to this issue’s fork.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Version: 8.x-1.0 » 2.1.1
Issue tags: +finalist-sprint
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Title: Support external file scheme .e.g S3 and make the entity itself translatable » Support external file scheme .e.g S3
Issue summary: View changes

I will spin off the translation issue into its own: #3616156: Make path_file entity translatable

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: -finalist-sprint

Let me know if you want to continue working on the remote support